Bug 1308046

Created attachment 1126198 [details]
build.log

Created attachment 1126199 [details]
root.log

Created attachment 1126200 [details]
state.log

This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

I will fix this!

Created attachment 1149114 [details]
Update-to-3.0.6 to fix test suite for Ruby 2.3 compatibility

*Highlight*
I updated to version 3.0.6 to fix test suite for Ruby 2.3 compatibility.
And I will upload rubygem-listen-3.0.6-tests.tgz that is test code for version 3.0.6 later.

I changed the logic to remove the hard coded dependencies from the patch file to the replacement with "sed" command. This new logic, do not need to update the patch file after updating the package version. It looks better.


*Package Dependencies*

I checked the impact for the dependency rubygem-listen v3.0.6.
f23 is not target in this time.

+ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem(listen)'
rubygem-rerun-0:0.10.0-3.fc23.noarch
rubygem-rerun-0:0.10.0-4.fc24.noarch
  => rpm spec file: ok
  => gem spec file: https://rubygems.org/gems/rerun/versions/0.10.0
  => this is working with rubygem-listen >= 3.0 by the patch.
rubygem-sass-0:3.4.4-2.fc23.noarch
vagrant-0:1.7.4-1.fc23.noarch
vagrant-0:1.8.1-1.fc23.noarch
vagrant-0:1.8.1-1.fc24.noarch
  Requires: rubygem(listen) >= 3.0.2
  Requires: rubygem(listen) < 3.1 
    => ok

+ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem-listen'
rubygem-listen-doc-0:3.0.3-1.fc23.noarch
rubygem-listen-doc-0:3.0.3-1.fc24.noarch
  => ok

+ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem(listen)'
rubygem-rerun-0:0.10.0-4.fc24.src
vagrant-0:1.8.1-1.fc24.src
  => ok

+ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem-listen'
  => No result

Created attachment 1149115 [details]
version 3.0.6 test files

(In reply to Jun Aruga from comment #5)
> I will fix this!

Thx. I approved you in PkgDB



(In reply to Jun Aruga from comment #6)
> Created attachment 1149114 [details]
> Update-to-3.0.6 to fix test suite for Ruby 2.3 compatibility
> 
> *Highlight*
> I updated to version 3.0.6 to fix test suite for Ruby 2.3 compatibility.
> And I will upload rubygem-listen-3.0.6-tests.tgz that is test code for
> version 3.0.6 later.
> 
> I changed the logic to remove the hard coded dependencies from the patch
> file to the replacement with "sed" command. This new logic, do not need to
> update the patch file after updating the package version. It looks better.

Of course this has bright sides (you don't need to update the patch when new version is release) and it has downsides (you don't have to check what was actually changed, if there are introduced new dependencies or removed the old ones, since the "sed" always works, hence some unexpected dependencies can sneak in). So to say, I'm fine with that change, just wanted to highlight possible impacts.

BTW you might consider to use this sed commands similar to this instead:

  sed -i -e '/^.*<rb-fsevent>.*$/ s/^/#/' ./listen-%{version}.gemspec

which just comments out the lines. Also, I am not sure if the /g in the pattern of your sed is really needed ...

jaruga's rubygem-listen-3.0.6-1.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=756501

Hi, Vit. 
Thanks for your review, and for the information of the possible impacts.

I used your way.
> sed -i -e '/^.*<rb-fsevent>.*$/ s/^/#/' ./listen-%{version}.gemspec

Actually I could replace multiplex target lines without "/g".
I did not need to use "/g" in this case. [1]

[1]
https://www.gnu.org/software/sed/manual/sed.html#The-_0022s_0022-Command
> g: Apply the replacement to all matches to the regexp, not just the first

rubygem-listen-3.0.6-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d04e36fa8d

rubygem-listen-3.0.6-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d04e36fa8d

rubygem-listen-3.0.6-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.