Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1308266

Summary: zidrav: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: zidravAssignee: Ralf Corsepius <rc040203>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dominik, itamar, rc040203
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-15 13:49:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
proposed patch none

Description Fedora Release Engineering 2016-02-13 22:44:15 UTC
Your package zidrav failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12880640

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 22:44:17 UTC
Created attachment 1126866 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 22:44:18 UTC
Created attachment 1126867 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 22:44:19 UTC
Created attachment 1126868 [details]
state.log

Comment 4 Ralf Corsepius 2016-02-15 05:35:33 UTC
Created attachment 1127164 [details]
proposed patch

The cause of this FTBFS is narrowing issues on i386 and arm.

The patch in the attachment should address these.
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=12990374

Unless somebody objects, I will apply these changes throughout the next couple of days.

Comment 5 Dominik 'Rathann' Mierzejewski 2016-02-15 08:34:44 UTC
Thanks for looking into this, Ralf. Your proposed patch doesn't contain the zidrav-gcc60.patch and I'd like to see it before you commit. Please add -b .gcc60 to %patch macro call. Other than that, I'm fine with your change (assuming the missing patch is ok).

Comment 6 Ralf Corsepius 2016-02-15 08:55:06 UTC
(In reply to Dominik 'Rathann' Mierzejewski from comment #5)
> Thanks for looking into this, Ralf. Your proposed patch doesn't contain the
> zidrav-gcc60.patch and I'd like to see it before you commit.
?!? It's there: https://bugzilla.redhat.com/attachment.cgi?id=1127164

Cut'n'paste from the URL above:

+diff -Naur zidrav4unix-1.2.0.orig/core.h zidrav4unix-1.2.0/core.h
+--- zidrav4unix-1.2.0.orig/core.h	2016-02-15 05:21:09.143118636 +0100
++++ zidrav4unix-1.2.0/core.h	2016-02-15 05:22:02.503690038 +0100
+@@ -48,7 +48,7 @@
+ #define QSV		KSigver( ZQ, QVER )
+ 
+ 
+-const long crc_table[256] = {		// it's just easier this way, alright? It's one K of data, I'm allowed a global if I want one
++const unsigned long crc_table[256] = {		// it's just easier this way, alright? It's one K of data, I'm allowed a global if I want one
+   0x00000000L, 0x77073096L, 0xee0e612cL, 0x990951baL, 0x076dc419L,
+   0x706af48fL, 0xe963a535L, 0x9e6495a3L, 0x0edb8832L, 0x79dcb8a4L,
+   0xe0d5e91eL, 0x97d2d988L, 0x09b64c2bL, 0x7eb17cbdL, 0xe7b82d07L,

This patch is a "git format-patch"-generated patch against git/master.
Just download this file and "git am <file>" in a clone of git/master.

Comment 7 Dominik 'Rathann' Mierzejewski 2016-02-15 10:02:02 UTC
My apologies, I can see it now. It wasn't showing up completely in the 'diff' view of bugzilla (https://bugzilla.redhat.com/attachment.cgi?id=1127164&action=diff). Feel free to apply. Thank you.

Comment 8 Ralf Corsepius 2016-02-15 13:49:40 UTC
Patch applied, package rebuilt for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=12992951