Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1310871
Summary: | Very slow shutdown, it takes 1 minute 30 seconds | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> | ||||
Component: | xfce4-power-manager | Assignee: | Christoph Wickert <cwickert> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 23 | CC: | cwickert, extras-qa, johannbg, jsynacek, lnykryn, msekleta, muadda, nonamedotc, s, systemd-maint, zbyszek | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | xfce4-power-manager-1.5.2-6.fc23 xfce4-power-manager-1.5.2-6.fc24 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | 1310608 | Environment: | |||||
Last Closed: | 2016-03-17 20:51:25 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Jaroslav Škarvada
2016-02-22 20:55:14 UTC
xfce4-power-manager-1.5.2-4.fc23.x86_64 Created attachment 1129701 [details]
Proposed fix
I think it segfaults because either 'vendor' or 'model' is NULL. I am not sure whether it is allowed, maybe there is also upower bug, but I think the client (xfce4-power-manager) should handle even such strange cases. The attached patch is my naive approach to fix the segfault. Maybe it's better to exit or do some different thing than just injecting empty string ("") instead of NULLs. I am now testing it whether it resolved the slow shutdown problem for me.
Upstream bugzilla: https://bugzilla.xfce.org/show_bug.cgi?id=12465 Thanks for filing the bug upstream. Is this happening on a laptop (I see thinkpad_acpi line) or on ac power? (In reply to Mukundan Ragavan from comment #4) > Thanks for filing the bug upstream. > > > Is this happening on a laptop (I see thinkpad_acpi line) or on ac power? Both. It seems the patch resolved the problem for me - no more crash in last two days. (In reply to Jaroslav Škarvada from comment #5) > (In reply to Mukundan Ragavan from comment #4) > > Thanks for filing the bug upstream. > > > > > > Is this happening on a laptop (I see thinkpad_acpi line) or on ac power? > > Both. > IIRC. I will try to locally modify the patch to find out what event is exactly sent there. Jaroslav, your patch has pushed to master branch upstream. I will add that patch and build it. Great, thanks. xfce4-power-manager-1.5.2-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-712eb3050d xfce4-power-manager-1.5.2-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-88fbd1a26c xfce4-power-manager-1.5.2-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-88fbd1a26c xfce4-power-manager-1.5.2-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-712eb3050d xfce4-power-manager-1.5.2-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. xfce4-power-manager-1.5.2-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |