Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1314927
Summary: | googletest 1.8.0 released: gmock and gtest merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> | ||||||||||
Component: | gmock | Assignee: | Terje Røsten <terjeros> | ||||||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
Severity: | unspecified | Docs Contact: | |||||||||||
Priority: | unspecified | ||||||||||||
Version: | 28 | CC: | dan.cermak, lemenkov, mattias.ellert, ngompa13, orion, releng, terjeros, thofmann | ||||||||||
Target Milestone: | --- | ||||||||||||
Target Release: | --- | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Whiteboard: | |||||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
Doc Text: | Story Points: | --- | |||||||||||
Clone Of: | Environment: | ||||||||||||
Last Closed: | 2018-03-15 08:18:00 UTC | Type: | Bug | ||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||
Documentation: | --- | CRM: | |||||||||||
Verified Versions: | Category: | --- | |||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
Embargoed: | |||||||||||||
Bug Depends On: | |||||||||||||
Bug Blocks: | 1305208 | ||||||||||||
Attachments: |
|
Description
Dominik 'Rathann' Mierzejewski
2016-03-04 22:31:51 UTC
Is there any gmock releases inside gtest yet? 1.7.0 seems to be 2-3 years old. A release with gcc 6 issues fixed would also help: https://github.com/google/googletest/issues/705 Do you know why they don't create releases any longer? This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. There now appears to be a 1.8.0 release: https://github.com/google/googletest/releases Created attachment 1196524 [details]
googletest.spec
Here's an initial attempt at a combined spec.
Hi! Thanks! Can you post the required file googletest-libdir.patch too? *** Bug 1307542 has been marked as a duplicate of this bug. *** *** Bug 1307602 has been marked as a duplicate of this bug. *** *** Bug 1284423 has been marked as a duplicate of this bug. *** Created attachment 1206622 [details]
googletest-libdir.patch
Hey, is someone working on importing this to replace gmock and gtest? I haven't progressed beyond what I attached. I have merged the googletest.spec with the already existing gtest.spec & gmock.spec files and it seems to work. It requires Orion's googletest-libdir.patch and also gtest-null-pointer.patch (otherwise the unit tests fail). In contrast to 1.7. there are however some differences: gtest-config and gmock-config do not exist anymore (the templates are still in the upstream sources, but they are not build by CMake, at least I don't know how). Also there is now only one libgtest.so and no libgtest.so.0 and libgtest.so.0.0 (I don't know enough about dynamic linking, so no clue where they came from). The same applies to libgtest_main.so, libgmock.so and libgmock_main.so (although the later two were not in the gmock-1.7.0 rpm). I have submitted the build to copr: http://copr-fe.cloud.fedoraproject.org/coprs/defolos/devel/build/628186/ Open questions: - I have included a call ldconfig in %install, but don't know if that is necessary - The Changelog is empty, it should be a combination of the gmock and gtest changelog (+ Orion's contribution). Should they be merged or a new changelog started? Created attachment 1338008 [details]
Merged spec for gtest and gmock
Created attachment 1338009 [details]
Required patch from the gtest rpm
Hi Dan, thanks for patches! Changes pushed to rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=22468376 Awesome! But I guess they aren't making it into 27, are they? This message is a reminder that Fedora 25 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '25'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 25 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. gmock needs to be retired. It doesn't look like it's marked as a dead package. This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. (In reply to Neal Gompa from comment #18) > gmock needs to be retired. It doesn't look like it's marked as a dead > package. Done. I think we may close this ticket now. |