Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1333295

Summary: FTBFS due compiler warnings in elf64-s390.c
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: crashAssignee: Dave Anderson <anderson>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anderson
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-05 14:19:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    

Description Dan Horák 2016-05-05 08:45:33 UTC
Latest crash fails to compile on s390x due

...
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -DTRAD_CORE -I. -I. -I./../include -DHAVE_bfd_elf64_s390_vec -DHAVE_bfd_elf32_s390_vec -DHAVE_bfd_elf64_little_generic_vec -DHAVE_bfd_elf64_big_generic_vec -DHAVE_bfd_elf32_little_generic_vec -DHAVE_bfd_elf32_big_generic_vec -DBINDIR=\"/usr/local/bin\" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -march=z9-109 -mtune=z10 -MT elf64-s390.lo -MD -MP -MF .deps/elf64-s390.Tpo -c elf64-s390.c -o elf64-s390.o
elf64-s390.c: In function 'elf_s390_reloc_name_lookup':
elf64-s390.c:319:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
   for (i = 0;
   ^~~
elf64-s390.c:326:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
     if (strcasecmp (elf64_s390_vtinherit_howto.name, r_name) == 0)
     ^~
cc1: all warnings being treated as errors
Makefile:1607: recipe for target 'elf64-s390.lo' failed
make[6]: *** [elf64-s390.lo] Error 1
...

please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2213030 for full logs

Version-Release number of selected component (if applicable):
crash-7.1.5-1.fc25

Comment 1 Dave Anderson 2016-05-05 13:55:13 UTC
I thought I was through with these new pain-in-the-ass gcc-6 warnings, but
I wasn't even aware that s390x was a secondary Fedora architecture.  
Anyway, the warning above has been addressed here:

  Information for build crash-7.1.5-2.fc25
  http://koji.fedoraproject.org/koji/buildinfo?buildID=760294

But I don't guarantee that there may not be other s390x-specific warnings
that will also need to be addressed.  Give it a shot and report back
here.

Comment 2 Dan Horák 2016-05-05 14:12:42 UTC
Looks good - http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2214724 - thanks.

You can do scratch build on secondary easily with
$arch-koji build --scratch f25 crash.src.rpm
where arch is arm (for aarch64), ppc (for ppc64, ppc64le) and s390 (s390x)

Comment 3 Dave Anderson 2016-05-05 14:19:15 UTC
(In reply to Dan Horák from comment #2)
> Looks good - http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2214724
> - thanks.
> 
> You can do scratch build on secondary easily with
> $arch-koji build --scratch f25 crash.src.rpm
> where arch is arm (for aarch64), ppc (for ppc64, ppc64le) and s390 (s390x)

Thanks Dan -- good to know...