Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1344261 (warsow)
Summary: | Review Request: warsow - Fast paced 3D first person shooter | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pete Walter <walter.pete> |
Component: | Package Review | Assignee: | Chris Sandler <chr77> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | chr77, klember, package-review, rosser.bjr, walter.pete |
Target Milestone: | --- | Flags: | chr77:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-02-03 19:18:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1344294 | ||
Bug Blocks: | 1364745 |
Description
Pete Walter
2016-06-09 09:39:26 UTC
Note that this goes together with the warsaw-data package from https://bugzilla.redhat.com/show_bug.cgi?id=1344294 Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14434169 Can you put both packages warsow (this bug) and warsaw-data (bug #1344294) in one spec file? warsaw-data could be a subpackage and is not much useful for its own alone. We could handle all in one single review. Are you interested in a review swap? Maybe with bug #1344115. > %global warsow_libdir %{_prefix}/lib/warsow … > # Filter private libraries from provides > %global __provides_exclude_from ^%{warsow_libdir}/.*\\.so$ … > # Install private libraries to a private directory > install -d $RPM_BUILD_ROOT%{warsow_libdir}/libs > install -m 755 libs/*.so $RPM_BUILD_ROOT%{warsow_libdir}/libs/ … %files %{warsow_libdir}/ This does not look right to me. Please explain why this private(?) folder must be used. You should use %{_libdir}/%{name} instead to also honor 64 bits with /usr/lib64/warsaw. > BuildRequires: /usr/bin/convert > BuildRequires: /usr/bin/desktop-file-install > BuildRequires: /usr/bin/dos2unix Better is to use concrete package names: BuildRequires: ImageMagick BuildRequires: desktop-file-utils BuildRequires: dos2unix You can verify with dnf whatprovides. (In reply to Raphael Groner from comment #3) > Can you put both packages warsow (this bug) and warsaw-data (bug #1344294) > in one spec file? warsaw-data could be a subpackage and is not much useful > for its own alone. We could handle all in one single review. I think two separate packages makes things simpler. They are built from separate tarballs and it makes packaging easier of they are separate SRPMs as well. > Are you interested in a review swap? Maybe with bug #1344115. Sorry, not really interested in wine stuff > > %global warsow_libdir %{_prefix}/lib/warsow > … > > # Filter private libraries from provides > > %global __provides_exclude_from ^%{warsow_libdir}/.*\\.so$ > … > > # Install private libraries to a private directory > > install -d $RPM_BUILD_ROOT%{warsow_libdir}/libs > > install -m 755 libs/*.so $RPM_BUILD_ROOT%{warsow_libdir}/libs/ > … > %files > %{warsow_libdir}/ > > This does not look right to me. Please explain why this private(?) folder > must be used. You should use %{_libdir}/%{name} instead to also honor 64 > bits with /usr/lib64/warsaw. Private folder is used because it installs private libraries that aren't meant for consumption by other apps. > > BuildRequires: /usr/bin/convert > > BuildRequires: /usr/bin/desktop-file-install > > BuildRequires: /usr/bin/dos2unix > > Better is to use concrete package names: > BuildRequires: ImageMagick > BuildRequires: desktop-file-utils > BuildRequires: dos2unix > > You can verify with dnf whatprovides. I disagree here. Spelling out what executable we need makes packaging much easier to understand. Review swap with bug #1364805? Are you interested in a review swap? Maybe you can take a look into bug #1385856? Sure, let's do that. Thanks. FTBFS You may need 'BuildRequires: pkgconfig(gl)' that installs mesa-libGL-devel including the missing %{_includedir}/GL/gl.h file. [ 8%] Building C object ref_gl/CMakeFiles/ref_gl.dir/r_alias.c.o cd /builddir/build/BUILD/warsow_21_sdk/source/source/cmake_build/ref_gl && /usr/bin/cc -DAPPLICATION_VERSION_HEADER=\"version.warsow.h\" -DFREETYPELIB_RUNTIME -DLIBCURL_RUNTIME -DLIBJPEG_RUNTIME -DLIBPNG_RUNTIME -DOGGLIB_RUNTIME -DTHEORALIB_RUNTIME -DUSE_SDL2 -DVORBISLIB_RUNTIME -DZLIB_RUNTIME -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -Dref_gl_EXPORTS -I/usr/include/SDL2 -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -pipe -Wall -Wno-unused-function -fvisibility=hidden -Winvalid-pch -std=gnu99 -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=500 -DNDEBUG -fno-strict-aliasing -ffast-math -funroll-loops -fPIC -o CMakeFiles/ref_gl.dir/r_alias.c.o -c /builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_alias.c In file included from /builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_glimp.h:70:0, from /builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_local.h:72, from /builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_alias.c:23: /builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/qgl.h:69:19: fatal error: GL/gl.h: No such file or directory #include <GL/gl.h> ^ compilation terminated. Ping? Are you still interested in this package? Right, thanks. I've added mesa-libGL-devel locally. Do you need a new SRPM? It's rather huge, I'd avoid uploading a new one unless you really need it. Yes, some new SPEC and SRPM files are needed to do another run of fedora-review. f-r tries to install the package in a mock environment, please provide warsow-data (rhbz#1344294) for completeness of runtime dependencies. FYI I'm currently moving and stuck with a limited internet connection, so the next run may not be expected in the next couple of weeks. No response so far. :( Raphael, I do not understand why you wanted to have warsow-data built to continue the review. Pete has a completely legitimate reason for not building it first (it would create broken dependencies in rawhide). Packaging here looks solid to me. Approving the review based on the earlier rpmfusion package review (https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762) and the review comments here. Thanks Pete, great work here! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/warsow Thanks! warsow-data-2.1-2.el7 warsow-2.1-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-56ee1f45bb warsow-data-2.1-2.fc24 warsow-2.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f2970d1d7 warsow-data-2.1-2.fc25 warsow-2.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff35e19cfe warsow-2.1-3.fc24, warsow-data-2.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f2970d1d7 warsow-2.1-3.fc25, warsow-data-2.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff35e19cfe warsow-2.1-3.el7, warsow-data-2.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-56ee1f45bb warsow-2.1-3.el7, warsow-data-2.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. warsow-2.1-3.fc25, warsow-data-2.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. warsow-2.1-3.fc24, warsow-data-2.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |