Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1351935

Summary: python3.5 ImportError on subprocess.mswindows
Product: [Fedora] Fedora Reporter: Emanuele Di Giacomo <emanuele>
Component: python-invokeAssignee: Othman Madjoudj <athmanem>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: athmanem
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-invoke-0.13.0-2.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 04:54:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for invoke/monkey.py none

Description Emanuele Di Giacomo 2016-07-01 08:13:00 UTC
Created attachment 1174837 [details]
Patch for invoke/monkey.py

Description of problem:
An ImportError exception is thrown when importing the module under python3.5.

Version-Release number of selected component (if applicable):
0.9.0-7.fc24

How reproducible:
always

Steps to Reproduce:
1. dnf install python3-invoke
2. python3 -c "import invoke"

Actual results:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.5/site-packages/invoke/__init__.py", line 2, in <module>
    from .tasks import task, ctask, Task
  File "/usr/lib/python3.5/site-packages/invoke/tasks.py", line 11, in <module>
    from .context import Context
  File "/usr/lib/python3.5/site-packages/invoke/context.py", line 3, in <module>
    from .runner import run
  File "/usr/lib/python3.5/site-packages/invoke/runner.py", line 5, in <module>
    from .monkey import Popen, PIPE
  File "/usr/lib/python3.5/site-packages/invoke/monkey.py", line 4, in <module>
    from subprocess import Popen as OriginalPopen, mswindows, PIPE
ImportError: cannot import name 'mswindows'

Expected results:

module successfully loaded.

Additional info:
Starting from python3.5, the submodule subprocess.mswindows was renamed subprocess._mswindows. A patch is provided as attachment.

Comment 1 Othman Madjoudj 2016-07-01 21:12:46 UTC
I'm going to rebase to 0.13.0 (already in rawhide).

Comment 2 Fedora Update System 2016-07-01 22:40:00 UTC
python-invoke-0.13.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5bf9314019

Comment 3 Fedora Update System 2016-07-02 20:28:44 UTC
python-invoke-0.13.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5bf9314019

Comment 4 Fedora Update System 2016-07-05 04:54:30 UTC
python-invoke-0.13.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.