Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1352215 (llvm37, llvm3.7)
Summary: | Review Request: llvm3.7 -- Versioned LLVM 3.7 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Milan Bouchet-Valat <nalimilan> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | j, orion, package-review, petersen |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-08-27 10:14:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1206852 |
Description
Milan Bouchet-Valat
2016-07-02 13:56:43 UTC
Jens, Orion: Since you've followed the review for llvm33, you're probably in the best position to review this new one. I am taking a look. Thanks! As per the latest guidelines, it seems that we don't actually have to follow the standard review process since LLVM is already packaged in Fedora: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Process I'd still appreciate your comments, and of course I need somebody other than me to validate the request. Yeah, I didn't see the point in reviewing something that had already been reviewed. Though I'm sure it could be cleaned up, there is probably utility in keeping the specs and organization similar between versions. I still need somebody to support my request in order to get the git repos set up. :-) Sorry, what request do you need to be validated? Have you requested your package in the package database? You can use this ticket as the reference. I can process the request, or if John does it first then he'll see this ticket. However, it is important to note that this package is not correctly named, and you only get the review exemption if you actually follow the naming guidelines. The name should be "llvm3.7". Unless it really is version thirty-seven. See https://fedoraproject.org/wiki/Packaging:Naming The fact that llvm33 and certainly other packages are doing it wrong isn't a good reason for failing to do it correctly now. Actually, I wanted to follow that naming convention too, but in the initial review I was asked to use llvm33 instead. Glad to see the guidelines have been made more explicit. I've changed it back to llvm3.7. I've just requested the creation of a new git repo. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/llvm3.7 llvm3.7-3.7.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a012749321 llvm3.7-3.7.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a012749321 llvm3.7-3.7.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. Thank you! How about building for F24 too? Do you need it there? If so, I can backport it of course. Milan - could you build this for EPEL7 too? Hmm, maybe hold of a bit. I'm trying to use it to compile pocl, but not having luck yet. (Works great for me with ghc-8.0 FWIW.) Jens: I was going to orphan llvm3.7 since Julia now uses llvm3.9, then I realized ghc depends on it on F26 (I had only checked F25...), so I reverted the change. But llvm3.7 still fails according to Koschei, so you may want to have a look before it's a problem for ghc. I've just orphaned llvm3.7 on F28 and rawhide since builds have started to fail and ghc no longer uses it. Okay, f27 ghc uses llvm3.7 |