Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1352711

Summary: Review Request: nodejs-is-generator-function - Determine if a function is an ES6 generator function or not
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Tom Hughes <tom>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, tom
Target Milestone: ---Flags: tom: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-13 17:35:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806, 1387531    

Description Jared Smith 2016-07-04 20:42:25 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-generator-function/nodejs-is-generator-function.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-generator-function/nodejs-is-generator-function-1.0.3-1.fc24.src.rpm
Description: Determine if a function is an ES6 generator function or not
Fedora Account System Username: jsmith

Comment 1 Tom Hughes 2016-07-11 21:19:19 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 5 files have
     unknown license. Detailed output of licensecheck in /home/tom/1352711
     -nodejs-is-generator-function/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: nodejs-is-generator-function-1.0.3-1.fc25.noarch.rpm
          nodejs-is-generator-function-1.0.3-1.fc25.src.rpm
nodejs-is-generator-function.noarch: W: summary-ended-with-dot C Determine if a function is an ES6 generator function or not.
nodejs-is-generator-function.noarch: W: only-non-binary-in-usr-lib
nodejs-is-generator-function.src: W: summary-ended-with-dot C Determine if a function is an ES6 generator function or not.
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
nodejs-is-generator-function.noarch: W: summary-ended-with-dot C Determine if a function is an ES6 generator function or not.
nodejs-is-generator-function.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/tom/1352711-nodejs-is-generator-function/srpm/nodejs-is-generator-function.spec	2016-07-11 22:13:30.953169924 +0100
+++ /home/tom/1352711-nodejs-is-generator-function/srpm-unpacked/nodejs-is-generator-function.spec	2016-07-04 21:37:10.000000000 +0100
@@ -7,5 +7,5 @@
 Version:	1.0.3
 Release:	1%{?dist}
-Summary:	Determine if a function is an ES6 generator function or not
+Summary:	Determine if a function is an ES6 generator function or not.	
 
 License:	MIT


Requires
--------
nodejs-is-generator-function (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-is-generator-function:
    nodejs-is-generator-function
    npm(is-generator-function)



Source checksums
----------------
https://registry.npmjs.org/is-generator-function/-/is-generator-function-1.0.3.tgz :
  CHECKSUM(SHA256) this package     : de491fafae7668f86ed963e737e755c0c1582f37c52a82e8d2754660ffd6424b
  CHECKSUM(SHA256) upstream package : de491fafae7668f86ed963e737e755c0c1582f37c52a82e8d2754660ffd6424b


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1352711
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Tom Hughes 2016-07-11 21:20:08 UTC
Make sure you use the version of the spec that doesn't have the trailing full stop on the summary, but other than that it looks fine.

Comment 3 Tom Hughes 2016-07-11 21:24:42 UTC
Also you should BR npm(make-generator-function) and enable the tests.

Comment 4 Gwyn Ciesla 2016-07-13 13:47:41 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-is-generator-function