Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1360388

Summary: tests fail in currency_test.go:155
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: golang-googlecode-textAssignee: Fridolín Pokorný <fpokorny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fpokorny, golang-updates, jchaloup, lsm5, vbatts
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-27 15:33:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    

Description Dan Horák 2016-07-26 14:52:39 UTC
The build of golang-googlecode-text package fails in the test phase with

...
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.vjXA3A
+ umask 022
+ cd /builddir/build/BUILD
+ cd text-6fc2e00a0d64b1f7fc1212dae5b0c939cf6d9ac4
+ export GOPATH=/builddir/build/BUILDROOT/golang-googlecode-text-0-0.12.git6fc2e00.fc25.s390x//usr/share/gocode:/usr/share/gocode
+ GOPATH=/builddir/build/BUILDROOT/golang-googlecode-text-0-0.12.git6fc2e00.fc25.s390x//usr/share/gocode:/usr/share/gocode
+ go test -compiler gc -ldflags '' golang.org/x/text/collate
ok  	golang.org/x/text/collate	0.012s
+ go test -compiler gc -ldflags '' golang.org/x/text/collate/build
ok  	golang.org/x/text/collate/build	0.004s
+ go test -compiler gc -ldflags '' golang.org/x/text/collate/colltab
ok  	golang.org/x/text/collate/colltab	1.260s
+ go test -compiler gc -ldflags '' golang.org/x/text/currency
--- FAIL: TestLinking (1.48s)
	currency_test.go:155: size(symbols)-size(base) was 902; want > 2K
FAIL
FAIL	golang.org/x/text/currency	1.482s
error: Bad exit status from /var/tmp/rpm-tmp.vjXA3A (%check)
    Bad exit status from /var/tmp/rpm-tmp.vjXA3A (%check)


for full logs please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2298382

This build is using golang.

Version-Release number of selected component (if applicable):
golang-googlecode-text-0-0.12.git6fc2e00.fc25

Comment 1 Jan Chaloupka 2016-07-26 15:41:55 UTC
Unless, it is a blocker, it does not get fixed. There are other go projects with its own set of failing tests. It would be more beneficial to fix more failing tests at once.

Keeping this bug opened but not guarantee any progress on it.

Comment 2 Jan Chaloupka 2016-07-26 15:42:42 UTC
Meaning, it is better to comment out the test rather than fix it.

Comment 3 Dan Horák 2016-07-27 08:22:50 UTC
I mean the question should be what is more likely wrong - golang-googlecode-text itself, the test case or even the compiler?

Comment 4 Jan Chaloupka 2016-07-27 11:05:24 UTC
The TestLinking compares size of two compiled binaries. First binary comes from this source code (e.g. as main1.go):

package main
import (
        "fmt"
        "golang.org/x/text/currency"
)
func main() {
        fmt.Print(currency.CLDRVersion)
}

The second one from (e.g. as main2.go):

package main
import (
        "fmt"
        "golang.org/x/text/currency"
)
func main() {
        fmt.Print(currency.Symbol(currency.USD))
}

Compiling the code on x86_64 with golang-1.6.2-1.fc25.x86_64 I have:
main1: 2971752
main2: 2992416

Evaluated condition from currency_test.go:154 that must hold:
size(main2) - size(main1) >= 2*1024


For x86_64 case: 2992416 - 2971752 = 20664 > 2048

Comment 5 Jan Chaloupka 2016-07-27 11:32:38 UTC
Compiling the code on s390x with golang-1.7-0.rc1.fc25.s390x I have:
main1: 2391609
main2: 2392511

The difference:
2392511 - 2391609 = 902 < 2048

Answering your question, the test case is not applicable on s390x.

Comment 7 Dan Horák 2016-07-27 12:47:23 UTC
s390 f25 build = http://s390.koji.fedoraproject.org/koji/buildinfo?buildID=420823