Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1364647
| Summary: | Review Request: nodejs-svgmin - Minify SVG files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, vanmeeuwen+fedora, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-22 14:04:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1364646, 1364959 | ||
| Bug Blocks: | 956806, 1364648, 1387531 | ||
|
Description
Jared Smith
2016-08-06 08:12:11 UTC
These need resolving:
nodejs-svgmin.noarch: E: zero-length /usr/lib/node_modules/svgmin/index.js
I do not see the RPM ship any other code? The tarball from npmjs.org seems to ship an empty index.js indeed.
nodejs-svgmin.src:19: W: macro-in-comment %{version}
nodejs-svgmin.src:42: W: macro-in-comment %setup
Note that 'npm search svgmin' does not return 'svgmin 0.1.0' and npmjs.org currently does not show the package metadata information because of a failure to find a readme.
Good catch... I've fixed this to pull index.js from GitHub instead of from the NPM tarball. This introduced a new dependency, nodejs-ware, which itself has a new dependency (nodejs-wrap-fn). Those have been submitted for package review. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgmin/nodejs-svgmin.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgmin/nodejs-svgmin-0.1.0-1.fc26.src.rpm Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgmin/nodejs-svgmin.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgmin/nodejs-svgmin-0.1.0-2.fc26.src.rpm All good, package accepted. 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1518' (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-svgmin In rawhide, closing bug |