Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1364699
Summary: | Review Request: nodejs-linefix - Recursively repair line endings | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-09-21 19:53:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 956806, 1387531 |
Description
Jared Smith
2016-08-06 09:56:59 UTC
It's looking like bin/fix.js is supposed to be made available as %{_bindir}/linefix (see README.md). Please note that bin/fix.js has the wrong interpreter as well. Fixed. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-linefix/nodejs-linefix.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-linefix/nodejs-linefix-0.1.1-2.fc26.src.rpm You're linking /usr/bin/linefix to /usr/lib/node_modules/linefix/bin/cmd.js, but that seems to need to be /usr/lib/node_modules/linefix/bin/fix.js Sorry, silly copy/paste error. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-linefix/nodejs-linefix.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-linefix/nodejs-linefix-0.1.1-3.fc26.src.rpm - Get the license directly from upstream: Source1: https://raw.githubusercontent.com/jhoff/linefix/master/LICENSE.txt And in %files %license LICENSE.txt Package otherwise accepted. 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1423' (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-linefix In rawhide, closing bug |