Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1364959
| Summary: | Review Request: nodejs-ware - Easily create your own middleware layer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, vanmeeuwen+fedora, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-22 13:28:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1364958, 1494224 | ||
| Bug Blocks: | 956806, 1364647, 1387531 | ||
|
Description
Jared Smith
2016-08-08 09:47:18 UTC
Can you please finish this package review? - Package is missing:
BuildRequires: npm(wrap-fn)
- Had to fix the test to match package.json, otherwise they fail:
%if 0%{?enable_tests}
mkdir -p node_modules/.bin/
ln -s %{_bindir}/mocha node_modules/.bin/mocha
make test
%else
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-ware/nodejs-ware.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-ware/nodejs-ware-1.3.0-1.fc28.src.rpm Even with your changes, I'm still having problems with the tests on this package :-( Package accepted. 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1516' (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-ware In rawhide, closing bug |