Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1364982
| Summary: | Review Request: nodejs-coffee-coverage - Istanbul and JSCoverage-style instrumentation for CoffeeScript files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-27 15:36:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1433783 | ||
| Bug Blocks: | 956806, 1315038, 1387531 | ||
|
Description
Jared Smith
2016-08-08 10:10:07 UTC
Can you please continue the package review? Please update to 2.0.1.
Many tests fail:
73 passing (2s)
2 pending
10 failing
1) Istanbul tests should find if branch with no else:
first statement
+ expected - actual
{
"end": {
+ "column": 29
- "column": 30
"line": 2
}
"start": {
"column": 0
at Context.<anonymous> (test/istanbul/test.coffee:162:68)
2) Istanbul tests should find switch/case branches:
first statement
+ expected - actual
{
"end": {
+ "column": 22
- "column": 23
"line": 6
}
"start": {
"column": 0
at Context.<anonymous> (test/istanbul/test.coffee:221:68)
3) Istanbul tests should work for a switch with no 'else':
AssertionError: expected { Object (line, loc, ...) } to deeply equal { Object (line, loc, ...) }
+ expected - actual
{
"line": 1
"loc": {
"end": {
+ "column": 22
- "column": 23
"line": 5
}
"start": {
"column": 0
at Context.<anonymous> (test/istanbul/test.coffee:256:46)
4) Istanbul tests should find functions:
first statement
+ expected - actual
{
"end": {
+ "column": 22
- "column": 23
"line": 2
}
"start": {
"column": 0
at Context.<anonymous> (test/istanbul/test.coffee:272:68)
5) Istanbul tests should find functions with parameters:
AssertionError: expected { Object (name, line, ...) } to deeply equal { Object (name, line, ...) }
+ expected - actual
}
"line": 1
"loc": {
"end": {
+ "column": 22
- "column": 23
"line": 2
}
"start": {
"column": 9
at Context.<anonymous> (test/istanbul/test.coffee:293:42)
6) Istanbul tests should correctly find the end of functions with extra whitespace:
AssertionError: expected { Object (name, line, ...) } to deeply equal { Object (name, line, ...) }
+ expected - actual
}
"line": 1
"loc": {
"end": {
+ "column": 22
- "column": 23
"line": 2
}
"start": {
"column": 9
at test/istanbul/test.coffee:307:46
at Array.forEach (<anonymous>:null:null)
at Context.<anonymous> (test/istanbul/test.coffee:301:22)
7) Istanbul tests should find multi-line functions:
first statement
+ expected - actual
{
"end": {
+ "column": 22
- "column": 23
"line": 6
}
"start": {
"column": 0
at Context.<anonymous> (test/istanbul/test.coffee:324:68)
8) Istanbul tests should find functions in a class:
class statement
+ expected - actual
{
"end": {
+ "column": 10
- "column": 11
"line": 4
}
"start": {
"column": 0
at Context.<anonymous> (test/istanbul/test.coffee:379:68)
9) Istanbul tests should find name of anonymous class:
class fn
+ expected - actual
}
"line": 1
"loc": {
"end": {
+ "column": 27
- "column": 28
"line": 3
}
"start": {
"column": 4
at Context.<anonymous> (test/istanbul/test.coffee:421:54)
10) Coverage tests should exclude directories specified from the project root when dynamically instrumenting code:
AssertionError: Code should have been instrumented: expected undefined to exist
at Context.<anonymous> (test/tests.coffee:53:78)
+ exit 10
Tests fail in Koji too. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-coffee-coverage/nodejs-coffee-coverage.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-coffee-coverage/nodejs-coffee-coverage-2.0.1-2.fc28.src.rpm Needs npm(minimatch) >= 3.0.2 (bug #1433783) Package accepted. 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1648' (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-coffee-coverage In rawhide, closing bug |