Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1370239
Summary: | Review Request: python-ansible-tower-cli - A CLI tool for Ansible Tower | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <fale> |
Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | germano.massullo, package-review |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | ignatenko:
fedora-review+
|
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-10-22 00:51:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1370473 | ||
Bug Blocks: |
Description
Fabio Alessandro Locati
2016-08-25 17:00:13 UTC
> It can be also be used as a client library for other python apps
then name should be python-ansible-tower-cli with appropriate py2/py3 subpackages.
> License: Apache 2.0 ASL 2.0 > BuildRequires: pythonX-tox I beleive you don't need it > BuildRequires: python-setuptools BuildRequires: python2-setuptools > Requires: python-six >= 1.7.2 Requires: python2-six > Requires: PyYAML >= 3.10 Requires: python2-PyYAML > Source0: https://files.pythonhosted.org/packages/source/a/%{name}/%{name}-%{version}.tar.gz try to use git tag > %{python3_sitelib}/ansible_tower_cli-%{version}-py?.?.egg-info or you completely harden it or you just use star. Also add trailing slash. %{python3_sitelib}/ansible_tower_cli-*.egg-info/ I think package name is correct. Also, I think there is no specific guidelines that says if a package contains some binary/script that uses its own python library then name it with python prefix. Correct me if i am wrong. (In reply to Parag AN(पराग) from comment #3) > I think package name is correct. Also, I think there is no specific > guidelines that says if a package contains some binary/script that uses its > own python library then name it with python prefix. Correct me if i am wrong. Can't find exact link now, but basically if it's library it should be available (if possible) for both py2 and py3. Current spec provides only py3 module. Which is not something completely wrong, but probably should be adjusted. As suggested by Igor, I've renamed the package and now it provides both the py2 and py3. It also provides ansible-tower-cli as meta-package that points to the py3 (if available) or py2. SRPM: https://fale.fedorapeople.org/rpms/python-ansible-tower-cli-3.0.0-2.fc24.src.rpm SPEC: https://fale.fedorapeople.org/rpms/python-ansible-tower-cli.spec Bug #1370473 is now closed and I think we could carry on with this :) I've packaged version 3.0.1: - SPEC: https://fale.fedorapeople.org/rpms/python-ansible-tower-cli.spec - SRPM: https://fale.fedorapeople.org/rpms/python-ansible-tower-cli-3.0.1-1.fc24.src.rpm - PATCH: https://fale.fedorapeople.org/rpms/tower-cli-fix_py35_tests.patch The patch is a cherrypick of https://github.com/ansible/tower-cli/commit/3317c834a30bb4c616eedad82a28bcd1f95bbe66). This patch does solve the assert_called problem with python 3.5 tests and was created to further debug BUG #1379773. Since ATM that bug is still open, I've commented out the python3 tests. Can we go forward with the review please? As soon as that bug is fixed, I'll re-add python3 tests I don't see any problems in packaging. APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-ansible-tower-cli python-ansible-tower-cli-3.0.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-77ab5bfecc python-ansible-tower-cli-3.0.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-18556cfcb3 python-ansible-tower-cli-3.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e996dab1a4 python-ansible-tower-cli-3.0.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-097c79ae7d python-ansible-tower-cli-3.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-ansible-tower-cli-3.0.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9339f62e16 python-ansible-tower-cli-3.0.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-ansible-tower-cli-3.0.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-ansible-tower-cli-3.0.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. python-ansible-tower-cli-3.0.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |