Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1373722

Summary: gegl03 FTBFS on aarch64
Product: [Fedora] Fedora Reporter: Yaakov Selkowitz <yselkowi>
Component: gegl03Assignee: Debarshi Ray <debarshir>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: high    
Version: 25CC: debarshir, nphilipp, pbrobinson, yselkowi
Target Milestone: ---Keywords: Patch, Reopened
Target Release: ---   
Hardware: aarch64   
OS: Linux   
Whiteboard:
Fixed In Version: gegl03-0.3.8-3.fc25 gegl03-0.3.8-3.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-22 00:25:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 922257    
Attachments:
Description Flags
Patch for rawhide none

Description Yaakov Selkowitz 2016-09-07 04:10:33 UTC
gegl03-0.3.8 FTBFS on aarch64 due to a crash while building the documentation.  Debugging shows a bogus return value from realpath in operations/core/load.c, stemming from:

load.c: In function 'do_setup':
load.c:121:30: warning: implicit declaration of function 'realpath' [-Wimplicit-function-declaration]
       gchar *resolved_path = realpath (path, NULL);
                              ^~~~~~~~
load.c:121:30: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
load.c:141:15: warning: implicit declaration of function 'free' [-Wimplicit-function-declaration]
               free (resolved_path);
               ^~~~
load.c:141:15: warning: incompatible implicit declaration of built-in function 'free'
load.c:141:15: note: include '<stdlib.h>' or provide a declaration of 'free'
load.c:145:11: warning: incompatible implicit declaration of built-in function 'free'
           free (resolved_path);
           ^~~~
load.c:145:11: note: include '<stdlib.h>' or provide a declaration of 'free'

This warning also occurs on armhfp but does not crash because it is a 32-bit arch.  The warning does not occur on x86_64 only because the OpenCL headers include xmmintrin.h thereon, which ultimately pulls in the entire stdlib.h.

The root cause is the erroneous removal of #include <stdlib.h> in:

https://git.gnome.org/browse/gegl/commit/?id=442f6832701c4fba63a3564e6dd5ff1b9583a3a6

operations/core/load.c needs to #include <stdlib.h> to fix this issue.

Comment 1 Yaakov Selkowitz 2016-09-07 04:35:52 UTC
Created attachment 1198507 [details]
Patch for rawhide

Successful aarch64 scratch build:

http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3709809

Please merge into all supported branches.

Comment 2 Peter Robinson 2016-09-07 11:29:34 UTC
Fixed in rawhide. Please add patch to upstream bug.

Comment 3 Fedora Update System 2016-09-07 12:33:52 UTC
gegl03-0.3.8-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-20d6d89c33

Comment 4 Fedora Update System 2016-09-07 13:05:25 UTC
gegl03-0.3.8-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-908fa6fdba

Comment 5 Fedora Update System 2016-09-09 06:27:38 UTC
gegl03-0.3.8-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-20d6d89c33

Comment 6 Fedora Update System 2016-09-12 13:20:07 UTC
gegl03-0.3.8-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2016-09-12 15:29:19 UTC
gegl03-0.3.8-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-908fa6fdba

Comment 8 Fedora Update System 2016-09-22 00:25:31 UTC
gegl03-0.3.8-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.