Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1375415

Summary:	pmlogger_check failed due to /etc/pcp/pmlogger/control.d/local.rpmsave
Product:	[Fedora] Fedora	Reporter:	Mark Goodwin <mgoodwin>
Component:	pcp	Assignee:	Nathan Scott <nathans>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	24	CC:	brolley, fche, lberk, mgoodwin, nathans, nkshirsa, pcp, scox
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.11.5-1 pcp-3.11.5-1.el5 pcp-3.11.5-1.fc24 pcp-3.11.5-1.fc23 pcp-3.11.5-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-25 16:16:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mark Goodwin 2016-09-13 03:53:33 UTC

Description of problem: "pmlogger_check failed" messages in syslog because there are multiple primary logger control files in /etc/pcp/pmlogger/control.d. Presumably the .rpmsave version was left over after an upgrade because it had been modified (I appended -t 30s some time in the past). These files probably should be marked %config(noreplace) in the spec I guess, but after an upgrade we'd end up with local.rpmnew, which would have the same problem.

Version-Release number of selected component (if applicable): 3.11.5-1 (not yet released)

$ grep LOCALHOSTNAME /etc/pcp/pmlogger/control.d/*
/etc/pcp/pmlogger/control.d/local:LOCALHOSTNAME	y   n	PCP_LOG_DIR/pmlogger/LOCALHOSTNAME	-r -T24h10m -c config.default
/etc/pcp/pmlogger/control.d/local.rpmsave:LOCALHOSTNAME	y   n	PCP_LOG_DIR/pmlogger/LOCALHOSTNAME	-r -T24h10m -c config.default -t 30s

Comment 1 Mark Goodwin 2016-09-13 03:58:31 UTC

$ cat /var/log/pcp/pmlogger/pmlogger_check.log
Restarting primary pmlogger for host "local:" ... process exited!
pmlogger_check: Error: failed to restart pmlogger
Current pmlogger processes:
UID        PID  PPID  C STIME TTY          TIME CMD

Contents of pmlogger output file "pmlogger.log" ...
Log for pmlogger on kilcunda started Tue Sep 13 13:55:05 2016
... trimmed ...
Log finished Tue Sep 13 13:55:05 2016
pmlogger_check: [/etc/pcp/pmlogger/control.d/local.rpmsave:3]
Error: Cannot start more than one pmlogger instance for archive directory "/var/log/pcp/pmlogger/kilcunda"
... logging for host "local:" unchanged

Comment 2 Nathan Scott 2016-09-13 04:08:55 UTC

Yeah, I think this is mainly just something that has to be watched for during an RPM upgrade ... but, perhaps we could also ignore any files suffixed with .rpmsave or .rpmnew in that subdirectory?

cheers.

Comment 3 Mark Goodwin 2016-09-13 07:07:11 UTC

Ignore them, but also warn. We could also have a %postin script that checks and warns too.

Comment 6 Mark Goodwin 2016-09-15 06:14:41 UTC

fixed in upstream commit ba1355032bfdc91bfabc39d3a2255015fa92ccb9

Comment 7 Fedora Update System 2016-09-27 20:22:00 UTC

pcp-3.11.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8d14b648a5

Comment 8 Fedora Update System 2016-09-28 05:56:58 UTC

pcp-3.11.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca5c041e73

Comment 9 Fedora Update System 2016-09-28 06:25:26 UTC

pcp-3.11.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b32e6fdc78

Comment 10 Fedora Update System 2016-09-29 01:16:09 UTC

pcp-3.11.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-63742f1d5b

Comment 11 Fedora Update System 2016-10-25 16:16:53 UTC

pcp-3.11.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-10-25 20:21:40 UTC

pcp-3.11.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-10-25 23:50:48 UTC

pcp-3.11.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-10-26 00:58:09 UTC

pcp-3.11.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.