Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1375535

Summary: openssh does not build without selinux support despite key present
Product: [Fedora] Fedora Reporter: Pavel Alexeev <pahan>
Component: opensshAssignee: Jakub Jelen <jjelen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jjelen, mattias.ellert, mgrepl, plautrba, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openssh-7.3p1-4.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-09 02:47:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
missing ifdefs none

Description Pavel Alexeev 2016-09-13 10:48:14 UTC 
Description of problem:

$ rpmbuild --define 'noselinux 1' --define '_sourcedir /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master' --define '_specdir /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master' --define '_builddir /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master' --define '_srcrpmdir /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master' --define '_rpmdir /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master' --define 'dist .fc26' --define 'fedora 26' --eval '%undefine rhel' --define 'fc26 1' --eval '%undefine fc24' -ba /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master/openssh.spec
+ umask 022
+ cd /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master
+ cd /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master
+ rm -rf openssh-7.3p1
+ /usr/bin/gzip -dc /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master/openssh-7.3p1.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd openssh-7.3p1
+ /usr/bin/bzip2 -dc /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master/pam_ssh_agent_auth-0.10.2.tar.bz2
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch #103 (openssh-5.8p1-packet.patch):'
+ /usr/bin/patch -p1 -b --suffix .packet --fuzz=0
+ pushd pam_ssh_agent_auth-0.10.2
+ echo 'Patch #300 (pam_ssh_agent_auth-0.9.3-build.patch):'
+ /usr/bin/patch -p2 -b --suffix .psaa-build --fuzz=0
+ echo 'Patch #301 (pam_ssh_agent_auth-0.9.2-seteuid.patch):'
+ /usr/bin/patch -p1 -b --suffix .psaa-seteuid --fuzz=0
+ echo 'Patch #302 (pam_ssh_agent_auth-0.9.2-visibility.patch):'
+ /usr/bin/patch -p2 -b --suffix .psaa-visibility --fuzz=0
+ echo 'Patch #306 (pam_ssh_agent_auth-0.10.2-compat.patch):'
+ /usr/bin/patch -p2 -b --suffix .psaa-compat --fuzz=0
+ echo 'Patch #305 (pam_ssh_agent_auth-0.9.3-agent_structure.patch):'
+ /usr/bin/patch -p2 -b --suffix .psaa-agent --fuzz=0
+ echo 'Patch #307 (pam_ssh_agent_auth-0.10.2-dereference.patch):'
+ /usr/bin/patch -p2 -b --suffix .psaa-deref --fuzz=0
++ cat /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master/pam_ssh_agent-rmheaders
+ rm -f authfd.c authfd.h atomicio.c atomicio.h bufaux.c bufbn.c buffer.h buffer.c cleanup.c cipher.h compat.h defines.h entropy.c entropy.h fatal.c includes.h kex.h key.c key.h log.c log.h match.h misc.c misc.h pathnames.h platform.h rsa.h ssh-dss.c ssh-rsa.c ssh.h ssh2.h uidswap.c uidswap.h uuencode.c uuencode.h xmalloc.c xmalloc.h
+ popd
+ echo 'Patch #501 (openssh-6.7p1-ldap.patch):'
+ /usr/bin/patch -p1 -b --suffix .ldap --fuzz=0
+ echo 'Patch #502 (openssh-6.6p1-keycat.patch):'
+ /usr/bin/patch -p1 -b --suffix .keycat --fuzz=0
error: Bad exit status from /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master/_tmp/rpm-tmp.NyEm7y (%prep)
    Bad exit status from /home/pasha/SOFT/FEDORA/_NOT_my/openssh/master/_tmp/rpm-tmp.NyEm7y (%prep)

Master branch.
Comment 1 Jakub Jelen 2016-09-15 14:35:08 UTC 
Created attachment 1201265 [details]
missing ifdefs

Thank you for the report. It looks like some parts of the SELinux patches got mixed up with the slightly related keycat patch some years ago, nobody tried that and I missed that yet during my cleanups.

Not applying some patches is not needed in this case, because all the SELinux related code is enclosed with #ifdefs and therefore not used. Can you try that it works for you if you apply the attached dist-git patch?

Note that side effect of disabling SELinux this way disables audit support too.
Comment 2 Fedora Update System 2016-09-29 15:21:06 UTC 
openssh-7.3p1-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-94293f91e8
Comment 3 Fedora Update System 2016-10-09 02:47:04 UTC 
openssh-7.3p1-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.