Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1375670
Summary: | Review Request: python26 - Version 2.6 of the Python programming language | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
Component: | Package Review | Assignee: | Charalampos Stratakis <cstratak> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | cstratak, package-review |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | cstratak:
fedora-review+
|
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-12-01 22:21:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Miro Hrončok
2016-09-13 16:12:16 UTC
On koji the build finishes successfully for f23, while this is not the case for copr f23 chroots. The issue here are zombie processes left behind due to a test case in test_thread.py, so there is a possibility, that the build service used cannot kill the processes at the end of the build (after the %check phase has ran). In order to avoid this, I would suggest applying this [patch] from upstream which was applied only on python 2.7. [patch] https://hg.python.org/cpython/rev/613196986c09/ Copr builds for f23 finish successfully with this commit: https://copr.fedorainfracloud.org/coprs/g/python/python26/build/457870/ Could you please commit (or PR) it into the GH repo? https://github.com/fedora-python/python26 Thanks (In reply to Miro Hrončok from comment #2) > Could you please commit (or PR) it into the GH repo? > https://github.com/fedora-python/python26 > > Thanks Is it required for this package to reserve a new patch number as stated at [0]? [0] https://fedoraproject.org/wiki/SIGs/Python/PythonPatches As the other patches are not numbered, I don't think so. Commited [0] and made new copr builds. Things seem fine. Testing it now starting from F23. [0] https://github.com/fedora-python/python26/commit/f5f9e7271aa6b2ff6400f40f6eee507421bcf2c5 Package is updated to 2.6.9, the latest patch version of Python 2.6 upstream: https://hg.python.org/cpython/raw-file/v2.6.9/Misc/NEWS Package is flat, meaning that there are no subpackages, all the files and directories are at the main package. As it seems there is no debug build. Binaries, as well as libraries and man pages are removed or renamed so they do not conflict with the system python package. The binary for this package is renamed to python26, and invoking it fires up the 2.6.9 shell. python(abi) is not required/provided. setuptools and pip are not bundled in this package as upstream started bundling them from python2 >= 2.7.9 and python3 >= 3.4. Tested on F23 VM which I upgraded to F24, F25 and rawhide. No regressions noted and nothing seems to conflict with base python package or anything else. _bsddb module is disabled since the dependencies for building python 2.6 with this module cannot be satisfied in released Fedora versions. Various fixes have been applied which were/are present on current python2 package (Python 2.7), in order for it to work properly. I would like to dig in two things [0][1] though before the package is accepted, although they do not seem problematic with a first look [0] https://github.com/fedora-python/python26/commit/aabf03169e2263865a33fa86268a2b0260bf3fd5 [1] https://github.com/fedora-python/python26/commit/8f9ecb10686e54ad913e8054b6e95745b1669a62 BuildRequires: python2 is added because of that [error] during build on Fedora 23 and Fedora 24 [error] ./Parser/asdl_c.py -h ./Include ./Parser/Python.asdl /usr/bin/env: 'python': No such file or directory Makefile:558: recipe for target 'Include/Python-ast.h' failed make: *** [Include/Python-ast.h] Error 127 It seems to be fixable as it is mentioned here [0], but it's not a blocker for accepting the package. [0] https://mail.python.org/pipermail/python-dev/2010-December/106425.html Package accepted. python26-2.6.9-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3d4cc5cc35 python26-2.6.9-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-af076fa537 python26-2.6.9-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-54c504f247 python26-2.6.9-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-54c504f247 python26-2.6.9-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |