Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1380524

Summary: jitterentropy-rngd 1.0.3-1 not built with $RPM_OPT_FLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: jitterentropy-rngdAssignee: Paul Wouters <pwouters>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: npmccallum, pwouters
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: jitterentropy-rngd-1.0.5-2.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-29 11:47:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968    

Description Ville Skyttä 2016-09-29 20:30:20 UTC
(In reply to Nathaniel McCallum from bug 1378160 comment #1)
> Review PASSED
> [...]
> ===== MUST items =====
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [...]
> ===== EXTRA items =====
> [...]
> [x]: Rpmlint is run on debuginfo package(s).
>      Note: There are rpmlint messages (see attachment).
> [...]
> jitterentropy-rngd-debuginfo.x86_64: E: debuginfo-without-sources

This should not have passed the review; it's not built with appropriate compiler flags. The specfile contains a comment that it must be built with -O0, but that's not a reason to drop all other compiler flags.

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

Here's one way to fix it:

-# Build must be done with -O0 - so ignore buildin make falgs
-make
+CFLAGS="$RPM_OPT_FLAGS" %make_build

Comment 1 Fedora End Of Life 2017-02-28 10:22:22 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 2 Ville Skyttä 2017-05-14 08:07:10 UTC
No comments, so I've pushed and built the fix plus another including license files to rawhide. All earlier distro versions need the fix, too, will leave taking care of that to maintainers.

Comment 3 Paul Wouters 2017-05-15 14:57:30 UTC
Your fix is wrong. As can be seen, your change causes a compile with -O2:

gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches   -m64 -mtune=generic -Wextra -Wall -pedantic -fPIE -pie -O0 -fstack-protector-strong -fwrapv --param ssp-buffer-size=4    -c -o jitterentropy-rngd.o jitterentropy-rngd.c

I'm discussing with upstream to see if the -O0 is still needed. If so, I will update your fix to re-introduce -o0.

Comment 4 Ville Skyttä 2017-05-15 14:58:42 UTC
(In reply to Paul Wouters from comment #3)
> your change causes a compile with -O2:

No, it doesn't. Look closer into the command line: "gcc -O2 ... -O0 ..."

Comment 5 Fedora End Of Life 2018-05-03 08:01:21 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 6 Fedora End Of Life 2018-05-29 11:47:10 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.