Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1385856
Summary: | Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Raphael Groner <projects.rg> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | extras-qa, guido.grazioli, nobody, package-review, projects.rg, raphael.groner, vascom2, walter.pete, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1196920 | Environment: | |
Last Closed: | 2017-03-05 18:55:50 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1196917, 1196918 |
Description
Raphael Groner
2016-10-17 19:47:59 UTC
Spec URL: https://raphgro.fedorapeople.org/review/daasi/shibboleth/log4shib.spec SRPM URL: https://raphgro.fedorapeople.org/review/daasi/shibboleth/log4shib-1.0.9-2.fc25.src.rpm Fedora Account System Username: raphgro Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16109291 *** Bug 1196920 has been marked as a duplicate of this bug. *** Pete, did you have a chance to run fedora-review? It would be great if we can achieve some progress with the Shibboleth stack in Fedora. No response so far. :( Please correct rpmlint error and warning: log4shib.x86_64: E: incorrect-fsf-address /usr/share/licenses/log4shib/COPYING log4shib.x86_64: W: file-not-utf8 /usr/share/doc/log4shib/THANKS I don't get this insistence on substituting all occurrences of the name with %name. For example, if I want to open the URL field in browser, c&p is not enough, I need to manually replace %name. IMHO, such changes are a cargo-cult. Just saying. Suggestions: make %{?_smp_mflags} → %make_build make install DESTDIR=%{buildroot} → %make_install + package name is OK + license is acceptable (LGPv2+) + builds and installs OK + provides/requires/buildrequires look correct + scriptlets are sane + fedora-review doesn't point out any issues Package is APPROVED. rpmlint: log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_key_create log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_getspecific log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_key_delete log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_setspecific I think that's related to the recent glibc changes, not a problem with this package. log4shib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblog4shib.so.1.0.9 /lib64/libnsl.so.1 log4shib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblog4shib.so.1.0.9 /lib64/libm.so.6 Both of those libraries are provided by glibc, so this extra dep is harmless. log4shib.x86_64: W: file-not-utf8 /usr/share/doc/log4shib/THANKS log4shib.x86_64: E: incorrect-fsf-address /usr/share/licenses/log4shib/COPYING Like Vasiliy said, you might want to fix those, or maybe notify upstream. NEWS is useless, can be dropped from %doc. There are some tests in tests/. Would be nice to add a %check section. If you still want to do the swap review, #1415331 is nice an simple. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/log4shib Imported into master/rawhide. Please let me know when you need packages for the other branches. (In reply to Vasiliy Glazov from comment #5) > Please correct rpmlint error and warning: > log4shib.x86_64: E: incorrect-fsf-address > /usr/share/licenses/log4shib/COPYING > log4shib.x86_64: W: file-not-utf8 /usr/share/doc/log4shib/THANKS It's not clear where to report that to. Is this also a bug of log4cpp where log4ship is forked from? |