Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1387447
Summary: | Review Request: php-sentry - PHP client for Sentry | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||||
Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | rawhide | CC: | fedora, package-review | ||||||||
Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2016-11-15 23:22:19 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Shawn Iwinski
2016-10-20 23:49:14 UTC
Created attachment 1215024 [details]
licensecheck.txt
Created attachment 1215025 [details]
phpci.log
phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 15 2016 18:25:40 CEST static analyze results
Created attachment 1215026 [details]
review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1387447
Buildroot used: fedora-rawhide-x86_64
Blockers: [!]: License field in the package spec file matches the actual license. Should be BSD and ASL 2.0 with a comment about Serializer.php being ASL 2.0 [!]: Requires correct, justified where necessary. php-cli missing (for /usr/bin/sentry) Notice: For now php-Monolog have # "raven/raven": "^0.13" %global raven_min_ver 0.13 %global raven_max_ver 1.0 Upstream have "require-dev": { "sentry/sentry": "^0.13", And: "suggest": { "sentry/sentry": "Allow sending log messages to a Sentry server", So, ensure version 1.5.0 is ok for Monolog. Just to check what composer pull (from monolog) - Installing sentry/sentry (0.13.0) Downloading: 100% Regarding monolog stuff: Great catch! I'll check out comparability. Hopefully I can at least package the latest sentry/sentry 0.x version (0.22.0). Downgraded to 0.2.0 (latest 0.x release) for php-Monolog (verified compatibility) and made fixes per comment 4. Spec URL: https://raw.githubusercontent.com/siwinski/rpms/47e74254d7e035220abc71352f9b59f9c05c1e73/php-sentry/php-sentry.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-sentry-0.22.0-1.fc24.src.rpm [x]: License field in the package spec file matches the actual license. [x]: Requires correct, justified where necessary. === APPROVED === THANKS for the review! -- and especially for catching the Monolog version constraint Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-sentry php-sentry-0.22.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-782ea745d0 php-sentry-0.22.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-759427ad21 php-sentry-0.22.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1c2866b16d php-sentry-0.22.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-311313e9de php-sentry-0.22.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-10bf41d9af php-sentry-0.22.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-10bf41d9af php-sentry-0.22.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-311313e9de php-sentry-0.22.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1c2866b16d php-sentry-0.22.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-759427ad21 php-sentry-0.22.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-782ea745d0 php-sentry-0.22.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. php-sentry-0.22.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-sentry-0.22.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. php-sentry-0.22.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. php-sentry-0.22.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |