Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1388248
Summary: | Perhaps update, ship python2/python3 packages | ||
---|---|---|---|
Product: | [Fedora] Fedora EPEL | Reporter: | Orion Poplawski <orion> |
Component: | python-flake8 | Assignee: | Matthias Runge <mrunge> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | epel7 | CC: | generalpenguin89, mcepl, me, mrunge |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-07-05 14:04:20 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1060408 | ||
Bug Blocks: | 1774038 |
Description
Orion Poplawski
2016-10-24 20:39:29 UTC
Ping. Any news? See bug #1774038: (In reply to Parag Nemade from comment #2) > I think this package also needs python3 flake8. I cannot find it in epel7. (In reply to Raphael Groner from comment #1) > Correction. > Additional info: > python2-transtats-cli is the only dependency left for python2-tabulate. > Please consider. As I'm already involved in python-tabulate for epel, I could take care of flake8 as well. Please assign me ACL if you agree. Thank you for stepping up! I have no interest in epel packages. Please make sure to update the default bz assignee. Next possibility to upgrade would be, when 7.9 is shipped. (In reply to Matthias Runge from comment #2) > Thank you for stepping up! I have no interest in epel packages. Please make > sure to update the default bz assignee. Next possibility to upgrade would > be, when 7.9 is shipped. Well, epel packages are known to follow Fedora not vice versa. It seems to be okay to merge from master with an older version. The major issue here is to keep compatibility with python3 in both branches. No idea if I'm already part of @python-sig, it should indirectly give me the needed commit rights in case. diff --git a/python-flake8.spec b/python-flake8.spec index feefd74..551f33b 100644 --- a/python-flake8.spec +++ b/python-flake8.spec[ […] -Version: 2.0 -Release: 5%{?dist} -Summary: Code checking using pep8 and pyflakes +Version: 3.7.7 +Release: 7%{?dist} Is this safe to update in epel7? No idea about (possible) ABI/API breakage to other dependencies. There's a (very old) commit for 2.1 as well, maybe better to use this in epel7? Propably: https://src.fedoraproject.org/rpms/python-flake8/c/2a60911ef86343c26d5043ed03f55a724a648961 or: https://src.fedoraproject.org/rpms/python-flake8/c/db4904a79c3e91fda266407a387da6addb84436d Version 2.5.5 with small fixes: https://src.fedoraproject.org/rpms/python-flake8/c/227e633f2d6d8060dec3d9e9a66c4f64ebb5e465?branch=master (In reply to Orion Poplawski from comment #0) > Description of problem: > > Couple issues - > > - Maybe time to update? FYI - pyflakes is being updated to 1.3.0 no issue with v1.6.0 now in epel7 > - Ship python2-flake8 merged v2.5.5 from master > - Ship python3 variant - this will require updates to python-mccabe and > python-pep8. python-pep8 is orphaned, why? (In reply to Raphael Groner from comment #7) > (In reply to Orion Poplawski from comment #0) … > python-pep8 is orphaned, why? (In reply to Matthias Runge from comment #2) > Thank you for stepping up! I have no interest in epel packages. ... That's not true. You've merged into epel7: https://src.fedoraproject.org/rpms/python-pep8/c/2be375dd9de2d202426769aa2752bcf10eb01274?branch=epel7 * Wed Feb 26 2014 Matthias Runge <mrunge> -1.4.6-2 - rename py3 version of pep8 to python3-pep8 (rhbz#1060408) - built for epel7 Anyways, python-pep8 as a dependency is dead due to upstream renaming. For reasons see discussion in devel mailing: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/AQJSLQOSX5D2TK2B6B7PSVSPFWMCOL7F/ > python-pep8 is orphaned, why?
because it was orphaned. what info do you need from me?
The update fails for python2 as well with an obviously too old version of python-pep8 in epel7, execution of tests give: AttributeError: 'module' object has no attribute 'normalize_paths' (In reply to Raphael Groner from comment #3) > (In reply to Matthias Runge from comment #2) … > No idea if I'm already part of @python-sig, it should indirectly give me the > needed commit rights in case. I'll try with a pull request as push gets refused. python-flake8]$ git push Counting objects: 15, done. Delta compression using up to 40 threads. Compressing objects: 100% (9/9), done. Writing objects: 100% (9/9), 1.87 KiB | 0 bytes/s, done. Total 9 (delta 3), reused 0 (delta 0) remote: Fall-through deny remote: Denied push for ref 'refs/heads/epel7' for user 'raphgro' remote: All changes have been rejected To ssh://raphgro.org/rpms/python-flake8 ! [remote rejected] epel7 -> epel7 (pre-receive hook declined) (In reply to Raphael Groner from comment #15) > https://src.fedoraproject.org/rpms/python-flake8/pull-request/5 Following the comments given to my PR, this tends to final in CANTFIX. The PR got closed. Can we close this bug as well? makes sense. |