Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1390477
Summary: | Review Request: gnome-shell-extension-do-not-disturb-button - Don't show desktop notifications until you're ready to look at them | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Audrey Yeena Toskin <audrey> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | noarch | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-03-28 00:24:40 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Audrey Yeena Toskin
2016-11-01 08:02:56 UTC
Summary should not end in a dot. + package name is ok + license is acceptable (GPLv2) + license is specified correctly + builds and installs OK + latest version Package looks good. I'll approve it when you are sponsored. Please fix the Summary when uploading. Okay, summary has been fixed, and updated files pushed. Same URLs. Updated to Do Not Disturb Button version 10. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-do-not-disturb-button/raw/master/gnome-shell-extension-do-not-disturb-button.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-do-not-disturb-button-10-1.fc25.src.rpm Hi Andrew, sorry for the delay. This package looks good, and you're doing nice work with other packages. I have sponsored you into the packagers group, use your powers for good and have fun! I'll try to review some other of your requests later, but no promises. You might need to find reviewers elsewhere. If you have any questions, always feel free to drop me an e-mail. * Updated to upstream version 53 * Better locale detection, files moved to system directory * Moved gschema file to system directory * Downgrade GNOME Tweak Tool from a Require to a Recommend Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-do-not-disturb-button/raw/master/gnome-shell-extension-do-not-disturb-button.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-do-not-disturb-button-11-1.fc26.src.rpm Sorry, it's upstream version 11 -- obviously, from the SRPM. Right, looks nice. If you haven't done this already, you should head over to https://admin.fedoraproject.org/pkgdb/request/package/. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-do-not-disturb-button At some point I think I missed one of the notifications for this thread, so I was a little confused about being added to the packagers group before all my package reviews were done. But I think I'm all caught up now. Thanks, Zbigniew. I'll find another reviewer for my other pending packages. Am I missing anything else I need to do for this package, or is the rest of the process automated from here? I've been checking PkgDB and Koji: * https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-do-not-disturb-button/ * https://koji.fedoraproject.org/koji/packageinfo?packageID=23928 Seems to me like everything should be done, but there haven't been the usual automated messages about adding the package to Fedora 24 - 27, and the package doesn't show up in a `dnf search`. > I was a little confused about being added to the packagers group before all my package reviews were done There's no requirement for any or all package reviews to be done before being added to the packagers group. It's customary to do one review, but there's not hard rule. (In particular some people do not add new packages and become comaintainers.) > Seems to me like everything should be done, but there haven't been the usual automated messages about adding the package to Fedora 24 - 27 See https://apps.fedoraproject.org/packages/gnome-shell-extension-do-not-disturb-button/. You need to make an "update" for F24-F26: https://bodhi.fedoraproject.org/updates/new. gnome-shell-extension-do-not-disturb-button-11-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43bea7fd06 gnome-shell-extension-do-not-disturb-button-11-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddc48b3309 gnome-shell-extension-do-not-disturb-button-11-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dca03a7238 gnome-shell-extension-do-not-disturb-button-11-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-43bea7fd06 gnome-shell-extension-do-not-disturb-button-11-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dca03a7238 gnome-shell-extension-do-not-disturb-button-11-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddc48b3309 gnome-shell-extension-do-not-disturb-button-11-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-do-not-disturb-button-11-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-do-not-disturb-button-11-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |