Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1394026
Summary: | SAS address parsing issue | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jérôme Carretero <cJ-redhat> |
Component: | python-blivet | Assignee: | Blivet Maintenance Team <blivet-maint-list> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 25 | CC: | anaconda-maint-list, awilliam, blivet-maint-list, cJ-redhat, g.kaviyarasu, jonathan, mkolman, pjones, robatino, sgallagh, tflink, vanmeeuwen+fedora, vponcova |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | RejectedBlocker AcceptedFreezeException | ||
Fixed In Version: | python-blivet-2.1.6-4.fc25 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-11-18 08:23:53 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1277290 |
Description
Jérôme Carretero
2016-11-10 20:50:32 UTC
I am proposing this as a Final blocker just because I cannot wait to see people's faces... Seriously, though, it's a violation of: "The installer must be able to complete an installation using any supported locally connected storage interface." SAS is a supported locally connected storage interface. https://fedoraproject.org/wiki/Fedora_25_Alpha_Release_Criteria#storage-interfaces pjones, this is in code you wrote: https://github.com/rhinstaller/blivet/commit/2c5bbf3f9a734240ac9f8621ccd7e27f97a806a7 the regex that's matched is: re_interface_unknown = re.compile(r'^(\S*)\s*unknown: (\S*) (\S*)\s*$') and then we do: self.sas_address = int(unknown_match.group(1), base=16) self.sas_lun = int(unknown_match.group(2), base=16) just looking at the line that matched and the capture groups, 'obviously' we want groups 2 and 3, not 1 and 2. But that seems so obvious it almost makes me think I'm missing something. +1 blocker Jerome, can you please test with this updates image and see if it fixes the bug? https://www.happyassassin.net/updates/1394026.0.img to use it, boot the installer with inst.updates=https://www.happyassassin.net/updates/1394026.0.img as a kernel parameter. Thanks! For the record, I don't think it really makes sense to take this as a blocker simply because we have no reliable testing capacity for SAS and have treated the test case for it pretty much as an in-joke for the last several releases. I'm intended to propose we revise the criterion to say something like 'commonly-used local storage interfaces' and include a list of what's specifically supported, e.g. PATA, SATA, VirtIO... I'm moving around this morning and may not be at the meeting the whole time, so logging my thoughts in-bug. I just ran a quick install on a machine with SAS drives and the install completed without issue. That being said, this machine does have a RAID controller with no RAID set up which could be enough of a HW difference to make the test result useless. Without knowing more about the machine that produced the original error, it's hard for me to say. I *think* (based on pjones' references) the bug may affect only EDD (that's Enhanced Disk Device...I think) 4.0 hardware. I have absolutely no idea how common that is. pjones likely knows more. Discussed at 2016-11-14 blocker review meeting: https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2016-11-14/f25-blocker-review.2016-11-14-17.00.html . Rejected as a blocker on the basis that we really don't want the criterion to cover interfaces we do not test regularly. We will discuss a specific criterion adjustment in more detail, but we are agreed that the criterion should be revised not to cover this issue. We did, however, accept it as a freeze exception issue. python-blivet-2.1.6-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-80f65e5670 Can you try this again with F25 RC-1.3? Download links can be found at the top of https://fedoraproject.org/wiki/Test_Results:Fedora_25_RC_1.3_Installation . Thanks! python-blivet-2.1.6-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-80f65e5670 python-blivet-2.1.6-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |