Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1394785

Summary: Review Request: lua-bitop - Lua Bit Operations Module
Product: [Fedora] Fedora Reporter: Andreas Schneider <asn>
Component: Package ReviewAssignee: Jakub Hrozek <jhrozek>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: asn, fszymanski, package-review
Target Milestone: ---Flags: jhrozek: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-28 16:26:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1394789    

Description Andreas Schneider 2016-11-14 13:05:01 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop.spec
SRPM URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop-1.0.2-1.fc24.src.rpm
Description: Lua Bit Operations Module
Fedora Account System Username: asn

This is required by neovim
Comment 1 Andreas Schneider 2016-11-15 10:21:32 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop.spec
SRPM URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop-1.0.2-2.fc24.src.rpm

Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16461221
Comment 2 Andreas Schneider 2016-11-15 12:05:25 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop.spec
SRPM URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop-1.0.2-3.fc24.src.rpm
Comment 3 Andreas Schneider 2016-11-15 12:11:22 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop.spec
SRPM URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop-1.0.2-4.fc24.src.rpm
Comment 4 Jakub Hrozek 2016-11-23 15:33:02 UTC 
It looks like this package already exists in Fedora:
https://admin.fedoraproject.org/pkgdb/package/rpms/lua-bitop/

I would suggest to ask the maintainer why it's marked as Obsolete..

Other than that, your package looks good and I would have approved it. Maybe we can resurrect the old lua-bitop and you can become its maintainer?
Comment 5 Andreas Schneider 2016-11-25 09:02:57 UTC 
I requested to resurrect the package.

Spec URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop.spec
SRPM URL: https://xor.cryptomilk.org/rpm/lua-bitop/lua-bitop-1.0.2-5.fc24.src.rpm
Comment 6 Jakub Hrozek 2016-11-25 10:16:03 UTC 
Thank you, approved.
Comment 7 Andreas Schneider 2016-11-28 16:26:46 UTC 
Not needed. luajit provides the same functionallity as builtin.