Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1394788
Summary: | Review Request: lua-mpack - Implementation of MessagePack for Lua | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Schneider <asn> |
Component: | Package Review | Assignee: | Jakub Hrozek <jhrozek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | asn, fszymanski, package-review |
Target Milestone: | --- | Flags: | jhrozek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-12-02 21:25:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1394789 |
Description
Andreas Schneider
2016-11-14 13:08:27 UTC
Spec URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack.spec SRPM URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack-1.0.3-2.fc24.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16461169 Spec URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack.spec SRPM URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack-1.0.3-3.fc24.src.rpm fedora-review complains: Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE-MIT is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text so please change: %doc LICENSE-MIT README.md to: %license LICENSE-MIT %doc README.md otherwise looks good to me Spec URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack.spec SRPM URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack-1.0.3-4.fc25.src.rpm Some more nitpicks I noticed after reading https://fedoraproject.org/wiki/PackagingDrafts/Lua and checking other lua spec files: 1) https://fedoraproject.org/wiki/PackagingDrafts/Lua says that packages should define: Requires: lua(abi) = %{luaver} I'm not sure if this is better or worse than: Requires: lua >= %{lua_version} that you used but I think requiring the ABI version would detect ABI breaks. 2) The specfile owns a directory also owned by lua, why? %dir %{lua_libdir} didn't you only want to own: %{lua_libdir}/mpack.so ? I'm sorry I didn't notice these the first time. If these nitpicks are resolved, I will approve the package :-) Spec URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack.spec SRPM URL: https://xor.cryptomilk.org/rpm/lua-mpack/lua-mpack-1.0.3-5.fc25.src.rpm Thank you, approved. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/lua-mpack lua-mpack-1.0.3-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5739610b8 lua-mpack-1.0.3-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5739610b8 lua-mpack-1.0.3-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |