Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1400109

Summary: enable MAD plugin
Product: [Fedora] Fedora Reporter: Peter Lemenkov <lemenkov>
Component: qmmpAssignee: Karel Volný <kvolny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: kvolny
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1409566 (view as bug list) Environment:
Last Closed: 2017-01-13 17:42:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1396139    
Bug Blocks: 1409566    

Description Peter Lemenkov 2016-11-30 13:26:23 UTC
Since mad was packaged recently (see bug 1396139), it's possible to add Mp3 decoding back. Please consider reenabling support for Mp3.

Comment 1 Karel Volný 2016-11-30 13:36:44 UTC
thanks for the heads up

mp3 support should be covered by the mpg123 plugin from qmmp-plugin-pack, however MAD plugin should be enabled too, right

note to myself: don't forget about the mimetypes handling!

Comment 2 Peter Lemenkov 2016-11-30 13:41:55 UTC
(In reply to Karel Volný from comment #1)
> thanks for the heads up
> 
> mp3 support should be covered by the mpg123 plugin from qmmp-plugin-pack,
> however MAD plugin should be enabled too, right

Honestly, now I'm not so sure. I wasn't aware of qmmp-plugin-pack package before so I wasn't aware that MP3 is available alreaduy. As fpor MP3 libs here is what I think.

I personally believe that the time for libmad is gone. 12-15 years ago MAD was ahead of mpg123 in terms of accuracy, performance, and features. But since then, MAD development was stalled, while mpg123 one was fully reloaded. Now mpg123 is conforming to MP3 standards, fast, feature-reach, and with active upstream.

If mp3 support is already there then why link against another library with the same functionality?

So if in doubts then just close it as NOTABUG.

Comment 3 Karel Volný 2017-01-13 17:42:18 UTC
(In reply to Peter Lemenkov from comment #2)
> If mp3 support is already there then why link against another library with
> the same functionality?

to be honest, I don't understand the upstream intentions and I couldn't care less to ask :-) but since the mpg123 plugin is in extra pack, I guess mad plugin in the base package wouldn't do any harm

https://koji.fedoraproject.org/koji/taskinfo?taskID=17269152