Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1404406
Summary: | fix building against lz4 (with new versioning scheme) | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Oliver Henshaw <oliver.henshaw> | |
Component: | systemd | Assignee: | systemd-maint | |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | high | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 25 | CC: | adrian, alanh, amessina, ayurtsev, charles-henri, chupaka, dinechin, johannbg, jsynacek, k2571822, k2683901, lnykryn, mike, msekleta, muadda, ssahani, s, systemd-maint, zbyszek | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | All | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | systemd-231-12.fc25 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1419912 (view as bug list) | Environment: | ||
Last Closed: | 2017-01-17 19:52:51 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1419912 |
Description
Oliver Henshaw
2016-12-13 18:37:15 UTC
I discussed this with ignatenkobrain (who built that last lz4), and I'm going to backport the patch before the next build of systemd. systemd-231-11.fc25.x86_64 was build without LZ4 support creating a lot of "Journal file ... uses an unsupported feature, ignoring file." https://kojipkgs.fedoraproject.org//packages/systemd/231/11.fc25/data/logs/x86_64/build.log ... checking for LZ4... no ... $ systemctl --version systemd 231 +PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ -LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN *** Bug 1413413 has been marked as a duplicate of this bug. *** @zbyszek Any idea, if the error message could be improved to actually say what feature is missing? In its current state, the message is pretty much useless. *** Bug 1413388 has been marked as a duplicate of this bug. *** systemd-231-12.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4e5bd2cfb9 systemd-231-12.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4e5bd2cfb9 (In reply to Jan Synacek from comment #4) > @zbyszek Any idea, if the error message could be improved to actually say > what feature is missing? In its current state, the message is pretty much > useless. It just compares versions. I don't think there's much to add to that. (In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > (In reply to Jan Synacek from comment #4144) > > @zbyszek Any idea, if the error message could be improved to actually say > > what feature is missing? In its current state, the message is pretty much > > useless. > > It just compares versions. I don't think there's much to add to that. How about the name of the feature flag it's incompat with? The detection is done by a set of m4 macros. One *could* make them better, but I don't think we should do that. Why? The part to detect lz4 and print a message if it is missing is already ~10 lines in configure.ac. If this was made to detect a proper error message, it'd likely be a few times that. Now consider that we have maybe 40 other libraries. If they were all detected in the same way, we could write one fancy function. But they are not, we'd need to write lots of macros. The only option that'd scale would be for the configuration system (i.e. autotools and pkg-config in this case) to provide better routines. This is not going to happen. We should just consider switching to something better, when something better exists. Meson certainly has a lot of potential, let's see how it develops. I think comment #4 was referring to the message ("...uses an unsupported feature") that systemd emits at runtime. On the subject of missing features at build time, you would need something like functionality tests outside the build system (so that they don't get configured out when the dependency is not met.) (In reply to Oliver Henshaw from comment #11) > I think comment #4 was referring to the message ("...uses an unsupported > feature") that systemd emits at runtime. Ah, OK. I guess we could do that. > On the subject of missing features at build time, you would need something > like functionality tests outside the build system (so that they don't get > configured out when the dependency is not met.) http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?id=25bd358ef1484b59ede5ea247febc0dabf01e821 systemd-231-12.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. (In reply to Kinston Hughes from comment #9) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #8149) > > (In reply to Jan Synacek from comment #4144150) > > > @zbyszek Any idea, if the error message could be improved to actually say > > > what feature is missing? In its current state, the message is pretty much > > > useless. > > > > It just compares versions. I don't think there's much to add to that. > > How about the name of the feature flag it's incompat with? (In reply to Zbigniew Jędrzejewski-Szmek from comment #12) > (In reply to Oliver Henshaw from comment #11164) > > I think comment #4165 was referring to the message ("...uses an unsupported > > feature") that systemd emits at runtime. > Ah, OK. I guess we could do that. Good, I've opened 1416201 for that. Can this change also be made available in Fedora 24. I cannot read my journal files in Fedora 24: journal uses an unsupported feature, ignoring file. Also breaks on Fedora 24. Backported to f24 http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=f24 |