Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1406517
| Summary: | Review Request: container-selinux - Summary: SELinux policies for container runtimes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Jan Chaloupka <jchaloup> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lsm5, package-review |
| Target Milestone: | --- | Flags: | jchaloup:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-14 03:51:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lokesh Mandvekar
2016-12-20 19:07:52 UTC
Spec URL: https://lsm5.fedorapeople.org/container-selinux/container-selinux.spec SRPM URL: https://lsm5.fedorapeople.org/container-selinux/SRPMS/container-selinux-1.12.4-29.gitb97d6ca.fc25.src.rpm Note: this just takes out the container-selinux parts from docker.spec and makes a standalone package out of it. We don't have a container-selinux version yet, so I'm just including docker's version number here as that's what was used for the container-selinux subpackage. The version of container-selinux soon to be released will probably be '2.0'. Based on [1] you are missing "Obsoletes: container-selinux < 2:1.12.5.13". Or whatever version of the docker is the latest in the time of building first container-selinux rpm from the new package. [1] https://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages I don't think you need to make the constraint relative:
Obsoletes: docker-selinux <= %{epoch}:%{version}-28
It should be enough to fix it with some comment what is the docker-selinux obsoleted by the particular NEVR. E.g.
Obsoletes: docker-selinux <= 2:1.12.4-28
Otherwise LGTM. Please, resolve the two issues. Once done, I will approve. Done Spec URL: https://lsm5.fedorapeople.org/container-selinux/container-selinux.spec SRPM URL: https://lsm5.fedorapeople.org/container-selinux/SRPMS/container-selinux-2.0-1.fc25.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/container-selinux container-selinux-2.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-67238cda2f container-selinux-2.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-92edc8ea7f container-selinux-2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-92edc8ea7f container-selinux-2.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |