Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1415451
Summary: | fish fails to install during %post in Fedora 25 Atomic Host | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Audrey Yeena Toskin <audrey> |
Component: | fish | Assignee: | Andy Lutomirski <luto> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 28 | CC: | jaswinder, jlebon, luto, oliver, oliver, walters |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-05-28 19:05:51 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1352154 |
Description
Audrey Yeena Toskin
2017-01-22 07:17:19 UTC
This should work if I understand ostree correctly. The %post scriptlet writes to sysconfdir, but that should be okay, I think. Given that the error comes from bwrap, I'm assuming that this is an rpm-ostree bug. Feel free to assign back to fish if there's something that fish could do better. This is another instance of https://bugzilla.redhat.com/show_bug.cgi?id=1367587 but for fish. Andy, see https://bugzilla.redhat.com/show_bug.cgi?id=1352154#c0 for more information. I suppose I could work around this in fish, but: could rofiles-fuse learn about O_APPEND? The current scriptlet in fish follows the packaging guideline's recommendation (or at least it did) and works more or less atomically. Also, will %postun have the same problem? I think with O_APPEND one could still get corrupted config files if interrupted halfway, and obviously a corrupted /etc/shells would be bad. So it's just general best practice to do the "atomic file replace" pattern. I'll see about getting the guidelines changed. As far as %postun - rpm-ostree doesn't run them and likely never will. Removing a package is constructing a new tree where that package isn't present. In general, a major goal of rpm-ostree is to be anti-hysteresis <https://en.wikipedia.org/wiki/Hysteresis> I think I disagree for technical reasons. For atomic-file-replace, the scriptlet will do, roughly: cp /etc/shells /tmp/foo echo whatever >>/tmp/foo mv -f /tmp/foo /etc/shells With O_APPEND support, that would change to: open("/etc/shells", O_APPEND | ...); # The FUSE helper copies the file and returns a writable fd write(...); In either case, if a different process writes to the file in between the copy and the replace, that write will get lost. If nothing else writes to the file, everything is fine. As a practical matter, the actual behavior should be essentially identical in both variants. Also, actually making the change to the scriptlet seems likely to be a bit of a pain. I would want to make sure that, on non-ostree systems, the mode, label, etc of /etc/shells isn't changed by the scriptlet. This is a bit awkward. I completely agree that we could make that change in rofiles-fuse. In fact, that would take us farther down the "more like overlayfs" path. But if you look at the evolution of overlayfs, there are some really awful hacks there due to it doing in kernel space what IMO is clearly better done in userspace. See e.g. http://marc.info/?l=linux-fsdevel&m=148458878412049&w=2 (FTR, I'd like to not rely on FUSE either, but rather have http://www.spinics.net/lists/linux-fsdevel/msg75085.html ) This message is a reminder that Fedora 25 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '25'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 25 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Still applicable with F27. This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. I never tested this in Fedora 29 (the last OSTree-based release to still be called Atomic Host), but `sudo rpm-ostree install fish` works fine for me in a virtual machine of Fedora 30 Silverblue. Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |