Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1419332 (deepin-shortcut-viewer)

Summary:	Review Request: deepin-shortcut-viewer - deepin shortcut viewer
Product:	[Fedora] Fedora	Reporter:	sensor.wen
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	felixonmars, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	deepin-shortcut-viewer-1.3.1-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-04 14:30:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1421047
Bug Blocks:	1465889, 1419317

Description sensor.wen 2017-02-05 13:50:21 UTC

Spec URL: https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-shortcut-viewer.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00501609-deepin-shortcut-viewer/deepin-shortcut-viewer-1.0.2-1.git760b082.fc25.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17610935

Description: deepin shortcut viewer

Fedora Account System Username: mosquito

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-07-24 13:54:50 UTC

+ package name is OK
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ builds and installs OK
+ Requires/Provides/BuildRequires look OK
+ no scriptlets necessary
+ build flags are honoured
+ rpmlint shows nothing useful
- no docs and no license: there's a LICENSE file, and some documentation files, not sure if those are useful. Please add least add %license LICENSE.

CuteLogger is bundled. It is not packaged for Fedora, so according to the guidelines [https://fedoraproject.org/wiki/Bundled_Software_policy], a tag should be added:
  Provides: bundled(CuteLogger)
If you know the version, also add "= <version>", but from a quick look at the sources, I don't see any version string there.

Comment 2 sensor.wen 2017-07-25 05:39:48 UTC

SPEC: https://raw.githubusercontent.com/FZUG/repo/168a491b88b2796266ae1d6350a2e48065a6f4f2/rpms/deepin_project/deepin-shortcut-viewer.spec

Thanks, i fixed it.

Comment 3 Zbigniew Jędrzejewski-Szmek 2017-07-25 12:31:07 UTC

Look good now. Package is APPROVED. When uploading please do one more thing: update the %description to say a bit more more, like "This program is used to display ... by ... when ...".

Comment 4 Gwyn Ciesla 2017-07-31 12:15:08 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/deepin-shortcut-viewer