Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1422046
Summary: | building nss-softokn prefers headers from nss-softokn-*devel, should prefer from build tree | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kai Engert (:kaie) (inactive account) <kengert> | |
Component: | nss-softokn | Assignee: | nss-nspr-maint <nss-nspr-maint> | |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 26 | CC: | dueno, emaldona, hkario, kdudka, kengert, rrelyea | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | nss-softokn-3.33.0-1.0.fc26 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1489380 (view as bug list) | Environment: | ||
Last Closed: | 2017-10-14 23:50:55 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: |
Description
Kai Engert (:kaie) (inactive account)
2017-02-14 11:17:03 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. The same happens with nss and nss-devel of incompatible versions. Daiki, is this something you could try to fix? The following info scattered as comments in the spec files is relevant. In our spec files we take advantage of the gcc-iquote dir option documented at http://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html#Directory-Options to place the in-tree directories at the head of the list of directories to be searched for for header files. This ensures a build even when system headers are older. Such is the case when starting an update with API changes or even private export changes. Once the buildroot has been bootstrapped the patch may be removed but it doesn't hurt to keep it. I should mention that Bob is of the opinion that we should enable the iquote.patch always. see http://pkgs.fedoraproject.org/cgit/rpms/nss-softokn.git/tree/nss-softokn.spec#n71 http://pkgs.fedoraproject.org/cgit/rpms/nss-softokn.git/tree/nss-softokn.spec#n132 http://pkgs.fedoraproject.org/cgit/rpms/nss-softokn.git/tree/nss-softokn.spec#n193 In nss.spec see http://pkgs.fedoraproject.org/cgit/rpms/nss.git/tree/nss.spec#n102 http://pkgs.fedoraproject.org/cgit/rpms/nss.git/tree/nss.spec#n195 http://pkgs.fedoraproject.org/cgit/rpms/nss-softokn.git/tree/nss-softokn.spec#n193 nss-util.spec doesn't have it. This is for nss headers only and does not address the case when npsr is the one that brings changes. (In reply to Elio Maldonado Batiz from comment #4) > nss-util.spec doesn't have it. And now I think it should. I have seen cases where new API's and constants where introduced in headers from util. Thank you for the explanation, Elio. So I guess the problem is the -iquote option is enabled in only specific subdirs (cmd/bltest and lib/softoken): http://pkgs.fedoraproject.org/rpms/nss-softokn/blob/f27/f/iquote.patch Are there any harm to enable it globally? I have done that in rawhide as: http://pkgs.fedoraproject.org/rpms/nss-softokn/blob/master/f/iquote.patch and the build succeeds: https://koji.fedoraproject.org/koji/taskinfo?taskID=21553242 Now fipstest is compiled with: cc -o Linux4.11_x86_64_cc_glibc_PTH_64_OPT.OBJ/fipstest.o -c -O2 -fPIC -m64 -pipe -ffunction-sections -fdata-sections -DHAVE_STRERROR -DLINUX -Dlinux -Wall -Werror -DXP_UNIX -DSHLIB_SUFFIX=\"so\" -DSHLIB_PREFIX=\"lib\" -DSOFTOKEN_LIB_NAME=\"libsoftokn3.so\" -DSHLIB_VERSION=\"3\" -UDEBUG -DNDEBUG -D_REENTRANT -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -I/usr/include/nspr4 -I/usr/include/nss3 -I/usr/include/nspr4 -iquote ../../../dist/Linux4.11_x86_64_cc_glibc_PTH_64_OPT.OBJ/../public/nss -iquote ../../../dist/Linux4.11_x86_64_cc_glibc_PTH_64_OPT.OBJ/../private/nss -I../../../dist/Linux4.11_x86_64_cc_glibc_PTH_64_OPT.OBJ/include -I../../../dist/public/nss -I../../../dist/private/nss -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic fipstest.c Note that the position of the -iquote option does not matter, as it's always preferred over -I for the quoted forms of #include. Thanks! Does this bug need to be cloned for nss or is it easy enough to be fixed without the additional bureaucracy? (In reply to Kamil Dudka from comment #7) > Thanks! Does this bug need to be cloned for nss or is it easy enough to be > fixed without the additional bureaucracy? No response for a week. Cloning now... nss-3.33.0-1.0.fc26 nss-softokn-3.33.0-1.0.fc26 nss-util-3.33.0-1.0.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-621c36fcb8 nss-3.33.0-1.0.fc26, nss-softokn-3.33.0-1.0.fc26, nss-util-3.33.0-1.0.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |