Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1428638
Summary: | Cannot install on i686 or ppc64 since criu dep added | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
Component: | docker | Assignee: | Antonio Murdaca <amurdaca> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 26 | CC: | adimania, admiller, amurdaca, dennis, dwalsh, gmarr, ichavero, jcajka, lsm5, marianne, miminar, nalin, riek, vbatts |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | i686 | ||
OS: | Linux | ||
Whiteboard: | AcceptedFreezeException | ||
Fixed In Version: | docker-1.13.1-5.git5be1549.fc26 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-03-30 19:24:39 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1349185 |
Description
Adam Williamson
2017-03-03 01:34:37 UTC
is this enough? ``` diff --git a/docker.spec b/docker.spec index b4d4b20..5191a0a 100644 --- a/docker.spec +++ b/docker.spec @@ -144,7 +144,9 @@ Requires: device-mapper-libs >= 1.02.90-1 Requires: skopeo-containers Requires: gnupg +%ifnarch i686 ppc64 Requires: criu +%endif # BZ#1399098 Requires: python-rhsm-certificates ``` Well, probably. But if you can do that, why is it 'Requires:' on other arches? What's the actual reason for the dependency? (In reply to Adam Williamson from comment #2) > Well, probably. But if you can do that, why is it 'Requires:' on other > arches? What's the actual reason for the dependency? criu is needed for containers checkpoint & restore via "docker checkpoint" and "docker restore". If criu isn't available on those arches I believe it's save to skip the Requires as the commands will nicely tell you criu isn't installed. Which means we should change this to an optional requires correct? isn't https://bugzilla.redhat.com/show_bug.cgi?id=1428638#c1 sufficient? It's sufficient to fix this problem, but it's worth considering whether the Requires: is correct in the first place, or if it would be better off as a Recommends: . If it was changed to a Recommends: , I believe that would also solve this problem. Given checkpoint&restore is an experimental docker feature, and we don't enable experimental in Fedora at all, I'm moving the Requires: to a Recommends: now. Dan, wdyt? Yes makes sense. Probably don't need it at all if the version of docker we ship does not cupport CRIU. changed to a Recommends in https://koji.fedoraproject.org/koji/taskinfo?taskID=18486056 let me know if that works out well Can you please also fix this for F26? proposing as a freeze exception for Alpha as it prevents us making all 32 bit x86 and ppc64 deliverables Discussed during the 2017-03-27 blocker review meeting: [1] The decision was made to classify this bug as an AcceptedFreezeException was made as it would be nice to have this fixed in Alpha release. [1] https://meetbot.fedoraproject.org/fedora-blocker-review/2017-03-27/f26-blocker-review.2017-03-27-16.01.txt docker-1.13.1-5.git5be1549.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6e04c798f1 docker-1.13.1-5.git5be1549.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |