Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1431444
Summary: | Review Request: molequeue - Desktop integration of high performance computing resources | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Antonio T. (sagitter) <anto.trande> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-04-09 16:42:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1431172, 1431445, 1431448 |
Description
Antonio T. (sagitter)
2017-03-12 15:51:17 UTC
- Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages Hm, upstream has unversioned libraries. So all users will have to be rebuilt in sync. It would be nice talk with upstream why this is a bad idea. Nothing you can do downstream though [https://www.redhat.com/archives/fedora-devel-list/2009-March/msg01155.html]. You should run ldconfig scriptlets anyway, I think [https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries]. Why not python3? Ah, OK, the code does not seem to be python3 compatible. Too bad. .tar.gz would be preferable to .zip, they're 30% smaller usually. This is a graphical application, it would be nice to add an appdata file https://fedoraproject.org/wiki/Packaging:AppData, and a desktop file. Especially the desktop file is important so that people can launch this without going to the console. This is a specialized application, so the appdata can be missing. + package name is OK + license is OK (BSD 3-clause) + license is specified correctly + builds and installs OK - scriptlets are missing (see above) + buildrequires, provides, requires look correct Looks good otherwise. %build cat >molequeue.desktop <<EOF [Desktop Entry] Name=HPC queuing system Exec=molequeue Terminal=false Type=Application Icon=molequeue EOF convert molequeue/app/icons/molequeue.ico molequeue/app/icons/molequeue.png %install for i in molequeue/app/icons/molequeue-*.png; do size="$(identify $i|cut -d' ' -f3)" echo install -Dpm0644 $i %{buildroot}%{_datadir}/icons/hicolor/$size/apps/molequeue.png done desktop-file-install --dir %{buildroot}%{_datadir}/applications/ molequeue.desktop (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > You should run ldconfig scriptlets anyway, I think > [https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries]. I have fully ignored the 'ldscripts' in these rpms. Scatterbrained. (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > - Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > Hm, upstream has unversioned libraries. So all users will have to be rebuilt > in sync. It would be nice talk with upstream why this is a bad idea. Nothing > you can do downstream though > [https://www.redhat.com/archives/fedora-devel-list/2009-March/msg01155.html]. > Asked to upstream: https://github.com/OpenChemistry/molequeue/issues/17 Spec URL: https://sagitter.fedorapeople.org/molequeue/molequeue.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/avogadro2/fedora-rawhide-x86_64/00528416-molequeue/molequeue-0.8.0-2.20161222giteb397e.fc27.src.rpm Duh, I thought we got rid of those terrible icon cache scriptlets, but apparently they are still required. + package name is OK + license is OK (BSD 3-clause) + license is specified correctly + builds and installs OK + scriptlets are OK + buildrequires, provides, requires look correct One issue, my fault: in the .desktop file: -Name=HPC queuing system +Name=MoleQueue +Comment=Manage HPC jobs from the system tray (Name is displayed in search, and the text was too generic.) Package is APPROVED. (I didn't check actual functionality, because I don't have the necessary setup, but the app seems to be functional.) Thank you. Spec URL: https://sagitter.fedorapeople.org/molequeue/molequeue.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/avogadro2/fedora-25-x86_64/00528765-molequeue/molequeue-0.8.0-2.20161222giteb397e.fc25.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/molequeue molequeue-0.8.0-2.20161222giteb397e.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-833b73f0b0 molequeue-0.8.0-2.20161222giteb397e.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1b32a53bd molequeue-0.8.0-2.20161222giteb397e.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-833b73f0b0 molequeue-0.8.0-2.20161222giteb397e.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1b32a53bd molequeue-0.8.0-2.20161222giteb397e.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. molequeue-0.8.0-2.20161222giteb397e.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |