Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1434997
Summary: | Review Request: python-openidc-client - A python OpenID Connect client with token caching and management | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mohan Boddu <mboddu> |
Component: | Package Review | Assignee: | Ralph Bean <rbean> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | ignatenko, package-review, psabata, rbean |
Target Milestone: | --- | Flags: | rbean:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-04-06 13:43:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mohan Boddu
2017-03-22 21:09:48 UTC
I'm willing to sponsor Mohan. Jan Kaluza said he would review this package; I'll review the review :) I have updated the spec file and did a new scratch build: Spec URL: https://mohanboddu.fedorapeople.org/python-openidc-client.spec SRPM URL: https://mohanboddu.fedorapeople.org/python-openidc-client-0.0-2.git5456800.fc25.src.rpm Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18569647 Description: A python OpenID Connect client with token caching and management Fedora Account System Username: mohanboddu Thanks Igor and Ralph for reviewing it. (In reply to Petr Šabata from comment #1) > I'm willing to sponsor Mohan. Jan Kaluza said he would review this package; > I'll review the review :) looks perfect to me ;) Mohan, just change version to "0", not "0.0". (In reply to Igor Gnatenko from comment #3) > (In reply to Petr Šabata from comment #1) > > I'm willing to sponsor Mohan. Jan Kaluza said he would review this package; > > I'll review the review :) > > looks perfect to me ;) > > Mohan, just change version to "0", not "0.0". I updated the spec with version set to "0". Requesting one more change: On line 78, the %files section needs to be specific to the python2 subpackage, like this: %files -n python2-openidc-client (In reply to Ralph Bean from comment #5) > Requesting one more change: > > On line 78, the %files section needs to be specific to the python2 > subpackage, like this: > > %files -n python2-openidc-client Changed the %files section to %files -n python2-openidc-client. Thanks. OK, only one issue, but it is minor and in my opinion we can pass this stage without resolving it: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). Explanation: You modified the .spec file based on the last comment but did not rebuild the source rpm. The review tooling complains that the two are out of sync. Make sure that you import only the latest specfile including the %files change when you import this to dist-git. Petr Sabata has said that he will sponsor you into the packager group. Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages, /usr/lib/python3.6 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Sourcex is a working URL. [x]: Spec use %global instead of %define unless justified. ===== ExTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Just a few more notes here. * According to the versioning guidelines, the release field for snapshots needs to include the snapshot date; in this case the format should be <release>.YYYYDDMM[<git|snap><shortcomit>]%{?dist}, so using your sources you should end up with something like... python-openidc-client-0-3.20170323git5456800.fc27. * You could reuse %{name} in your URL. Actually, it turns out Mohan's been a packager this whole time. There's nothing for me to do here :) Updated Spec File: https://mohanboddu.fedorapeople.org/python-openidc-client.spec Updated SRPM: https://mohanboddu.fedorapeople.org/python-openidc-client-0.0-2.git5456800.fc25.src.rpm New Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18637653 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-openidc-client python-openidc-client-0-3.20170327git5456800.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f894201567 python-openidc-client-0-3.20170327git5456800.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c63445711a python-openidc-client-0-3.20170327git5456800.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a4642d91d python-openidc-client-0-3.20170327git5456800.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c63445711a python-openidc-client-0-3.20170327git5456800.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f894201567 python-openidc-client-0-3.20170327git5456800.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a4642d91d python-openidc-client-0-3.20170327git5456800.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. python-openidc-client-0-3.20170327git5456800.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-openidc-client-0-3.20170327git5456800.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |