Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1440110
Summary: | Midnight Command 4.8.19 has broken keymapping for Copy & Move | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ali Akcaagac <aliakc> |
Component: | mc | Assignee: | Jindrich Novy <novyjindrich> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 26 | CC: | alekcejk, dvlasenk, jsafrane, jskarvad, nerijus, novyjindrich, olegon, pahan, plroskin, segg.gill, slavazanko, van.de.bugger |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | mc-4.8.19-2.fc26 mc-4.8.19-2.fc25 mc-4.8.19-2.fc24 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-05-09 21:24:50 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ali Akcaagac
2017-04-07 10:12:39 UTC
Shift + F6 which used to be "Move As" now deletes files. Bad if someone has "delete confirmation" disabled. An operation that used to be "Move As" with dialog and feedback turns out to become "delete" without feedback (if confirmation was disabled". This is a huge regression that may lead to fatal misbehaviour AND possible and not intended data loss. I opened a bugreport at: http://midnight-commander.org/ticket/3807 ... and figured out that the issue is related by the switch from "slang" to "ncurses". NCurses somehow misaligns the Fx Keys (in combination with Shift, Alt, Ctrl) to other keys. You can find more information in the ticket above... Also related another ticket... http://midnight-commander.org/ticket/3254 The problem really is, that NCurses misaligns the Fx Keys to other Fx Keys and thus causing midnight commander to execute other operations that expected. This issue also causes Fx Keys that had a different function to now do something totally differently (overwriting the function). So either there is an issue with NCurses or it might be necessary to switch back from ncurses to slang. Otherwise midnight commander's functionality stays broken... *** Bug 1439886 has been marked as a duplicate of this bug. *** Please note that mc compiled with ncurses cannot use "Learn Keys" to redefine keys. The keys are captured correctly, but take not effect. I believe mc can do raw input with ncurses when learning keys. However, ncurses is allowed to process keys when no learning keys. I agree that mc should switch from F1x notation to Shift-Fx. F15 is "local copy" because F15 is Shift-F5, and F5 is "copy". Interpreting F15 as Shift-F3 breaks that natural connection. I believe the ncurses support in mc has never been on by default, so it's less tested. If the Fedora mc maintainers insist on using ncurses, they should patch mc to treat Shift-Fn as F(10+n). This is exactly the same bug which existed years ago. Unfortunately, I can't find it in bugzilla right now. It's very sad that regression testing is non-existent in mc and it's always in a state of permanent brokenness, trading one bug for another. (In reply to vvs from comment #5) > This is exactly the same bug which existed years ago. This is more a bug in ncurses and the way mc is using it. But the regression appeared because the fedora maintainer chose to change slang to ncurses in the configure options. Please read more about it here: https://bugzilla.redhat.com/show_bug.cgi?id=1436394 The issue has been reverted but the new spec hasn't been committed to git. Sorry, I wasn't finger-pointing to anybody. Shit happens and more often than not it's in a foreign libraries. What I meant was that mc desperately needs a regression test suite more than anything else. Especially, when such a bug can be traced to as long ago as https://bugzilla.redhat.com/show_bug.cgi?id=1389 Otherwise it's doomed to repeat again and again. (In reply to Ali Akcaagac from comment #6) > (In reply to vvs from comment #5) > > This is exactly the same bug which existed years ago. > > This is more a bug in ncurses and the way mc is using it. But the regression > appeared because the fedora maintainer chose to change slang to ncurses in > the configure options. Please read more about it here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1436394 > > The issue has been reverted but the new spec hasn't been committed to git. Yes, it's still not in dist-git. The change has been also made in f25. It's not good to introduce such changes (i.e. library switch) to stable releases. Very bad surprise is to delete files by Shift-F6... I expected more stability from well known commander, I love... :( Is any workaround? Only downgrade? Contacting FESCo at beginning of next month. https://bugzilla.redhat.com/show_bug.cgi?id=1436394#c34 Not only Shift-Fx are broken, ctrl-<arrows>, ctrl-home and ctrl-end are not working in mcedit, which renders it unusable for me. mc-4.8.19-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b205eabf4 mc-4.8.19-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf0dcd75c6 mc-4.8.19-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-70c2e0ec52 mc-4.8.19-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-70c2e0ec52 mc-4.8.19-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b205eabf4 mc-4.8.19-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf0dcd75c6 mc-4.8.19-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. mc-4.8.19-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. mc-4.8.19-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |