Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1451953
Summary: | Incorrect timestamps on unzipped files. | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Karel <chris.karel> | ||||
Component: | unzip | Assignee: | Petr Stodulka <pstodulk> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 25 | CC: | jirka, pstodulk | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | unzip-6.0-32.fc25 unzip-6.0-34.fc26 unzip-6.0-34.fc27 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2017-07-19 16:22:03 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Chris Karel
2017-05-18 01:59:39 UTC
Although `zip` stores both the legacy ZIP "DOS" timestamp (with 2-second precision) and an extension block with proper Unix timestamp, `unzip` is not using the latter during extraction because of a bug. Apart from the possible 1 second difference this has also negative implications when working across multiple time zones. Because the legacy timestamp uses local time zone, when e.g. someone packs source code in UTC+2 and someone else uses it later in UTC-8, their project will be always rebuilding for the next 10 hours, because `make` thinks the sources are still newer than the build outputs. Unfortunately it seems the upstream Info-ZIP folks still don't have anything like a repo to check for updates since 2009, but luckily Debian already has a patch for this: http://sources.debian.net/patches/unzip/6.0-21/17-restore-unix-timestamps-accurately.patch/ I have verified their version 6.0-21 does the right thing. Thanks for your consideration. Thanks Jirka for your time & investigation. Yes, repositories of (un)zip are not public and probably will not be. unzip-6.0-34.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-28fd8ef47d unzip-6.0-32.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-077cbd8617 unzip-6.0-32.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-077cbd8617 unzip-6.0-34.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-28fd8ef47d unzip-6.0-34.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. unzip-6.0-32.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |