Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1459642
Summary: | Duplicated entries of users and groups in lxqt-admin-user | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jia Yuan Lo <jylo06g> | ||||||
Component: | lxqt-admin | Assignee: | Raphael Groner <projects.rg> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 26 | CC: | helio, lxqt-sig, projects.rg | ||||||
Target Milestone: | --- | Keywords: | Patch, Reopened | ||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | https://github.com/lxde/lxqt/issues/1308 | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | lxqt-admin-0.11.1-5.fc26 lxqt-admin-0.11.1-5.fc24 lxqt-admin-0.11.1-5.fc25 | Doc Type: | If docs needed, set a value | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2017-06-16 13:18:03 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Jia Yuan Lo
2017-06-07 17:05:27 UTC
It's doubtful to see any relation to sddm or KDE in general. IMHO the method UserManager::loadUsersAndGroups() is b0rken due to there's no check implemented for duplications: https://github.com/lxde/lxqt-admin/blob/master/lxqt-admin-user/usermanager.cpp#L55 Do you have any users in several groups? What happens if you create a new user as membor of just one group? (In reply to Jia Yuan Lo from comment #0) > Created attachment 1285856 [details] > Screenshot 1 Okay, every user is listed twice. That might be because each user found from /etc/passwd by getgrent() gets added a second time [1] to the collected lists of groups and members generated from getgrent(), nevertheless what getgrent() [2] reports. It seems worth to report this to upstream. [1] https://github.com/lxde/lxqt-admin/blob/master/lxqt-admin-user/usermanager.cpp#L78 [2] https://github.com/lxde/lxqt-admin/blob/master/lxqt-admin-user/usermanager.cpp#L65 Reported upstream: https://github.com/lxde/lxqt/issues/1308 Thanks. Upstream has a patch, please apply. https://github.com/lxde/lxqt-admin/pull/47 Created attachment 1286341 [details]
[PATCH] lxqt-admin-user: Check for duplicates from getgrent, getpwent
lxqt-admin-0.11.1-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c84af76d19 lxqt-admin-0.11.1-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e27250dafa lxqt-admin-0.11.1-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f20a0e6e4c lxqt-admin-0.11.1-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f20a0e6e4c lxqt-admin-0.11.1-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c84af76d19 lxqt-admin-0.11.1-5.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e27250dafa lxqt-admin-0.11.1-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. lxqt-admin-0.11.1-5.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. lxqt-admin-0.11.1-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |