Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1460148

Summary:	dependency on criu broken for s390x
Product:	[Fedora] Fedora	Reporter:	Dan Horák <dan>
Component:	runc	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amurdaca, bbaude, bugproxy, dwalsh, golang-updates, hannsj_uhl, jchaloup, lsm5, TicoTimo
Target Milestone:	---
Target Release:	---
Hardware:	s390x
OS:	Unspecified
Whiteboard:
Fixed In Version:	runc-1.0.1-1.gitc5ec254.fc26 runc-1.0.1-1.gitc5ec254.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-31 16:20:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	467765

Description Dan Horák 2017-06-09 09:09:04 UTC

Currently runc can't be installed on s390x, because there is a hard dependency on criu which doesn't exist for s390x (yet?)

Error: conflicting requests
  - nothing provides criu needed by runc-1:1.0.0-7.git6394544.fc27.1.s390x
(try to add '--allowerasing' to command line to replace conflicting packages)

But if I read the runc code right, then it should affect only the checkpoint and restore functionality. Can't we just skip the dependency on s390x?

eg. with
diff --git a/runc.spec b/runc.spec
index 1b948f2..2133e6e 100644
--- a/runc.spec
+++ b/runc.spec
@@ -70,7 +70,9 @@ BuildRequires: golang(github.com/vishvananda/netlink)
 BuildRequires: golang(github.com/vishvananda/netlink/nl)
 %endif
 
+%ifnarch s390x
 Requires: criu
+%endif
 
 %description
 The runc command can be used to start containers which are packaged



Version-Release number of selected component (if applicable):
runc-1:1.0.0-7.git6394544.fc27.1.s390x

Comment 1 Lokesh Mandvekar 2017-06-26 14:23:24 UTC

Hi Dan, do you know if Recommends: criu will work instaead? I can send you a scratch build to test this if needed.

Seems like this bug exists for i686 as well.

Comment 2 Dan Horák 2017-06-26 16:23:08 UTC

Hi Lokesh, after reading https://fedoraproject.org/wiki/Packaging:WeakDependencies I think "Recommends: criu" should be used in general for runc as criu is a non-mandatory dependency, but should not be used to "skip" the missing criu on eg. s390x (even weak deps should be resolvable in the repos).

See bug 1456513 for the enterprise view on a similar problem, but I would still add the %ifarch guard.

Comment 3 Fedora Update System 2017-06-26 23:19:37 UTC

runc-1.0.0-9.git6394544.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-354fc34a7c

Comment 4 Fedora Update System 2017-07-20 16:09:34 UTC

runc-1.0.1-1.gitc5ec254.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-20cdb2063a

Comment 5 Fedora Update System 2017-07-20 16:09:59 UTC

runc-1.0.1-1.gitc5ec254.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-41ae78baf9

Comment 6 Fedora Update System 2017-07-23 06:55:54 UTC

runc-1.0.1-1.gitc5ec254.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-20cdb2063a

Comment 7 Fedora Update System 2017-07-23 09:57:54 UTC

runc-1.0.1-1.gitc5ec254.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-41ae78baf9

Comment 8 Fedora Update System 2017-07-31 16:20:31 UTC

runc-1.0.1-1.gitc5ec254.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-07-31 20:20:13 UTC

runc-1.0.1-1.gitc5ec254.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.