Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1462412
Summary: | Review Request: tworld - a puzzle game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Artur Frenszek-Iwicki <fedora> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | musuruan, package-review, samuel-rhbugs, tcallawa, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-07-06 02:22:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1364745 |
Description
Artur Frenszek-Iwicki
2017-06-17 11:49:08 UTC
rpmlint: tworld-data.noarch: E: incorrect-fsf-address /usr/share/licenses/tworld-data/COPYING Who cares? ;) tworld.x86_64: W: manual-page-warning /usr/share/man/man6/tworld.6.gz 2: warning: macro `LO' not defined The page seems to display OK, so this can be ignored. 4 packages and 0 specfiles checked; 2 errors, 8 warnings. make %{?_smp_mflags} → %make_build, optionally. $ appstream-util validate /usr/share/appdata/tworld.appdata.xml /usr/share/appdata/tworld.appdata.xml: FAILED: • tag-invalid : <metadata_license> is not valid [CC-BY-SA-3.04.0] • tag-invalid : <project_license> is not valid [GPLv2+]SPDX ID 'GPLv2+' unknown • tag-missing : <translation> not specified • tag-missing : <update_contact> is not present • attribute-invalid : <screenshot> width too small [http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg] • attribute-invalid : <screenshot> height too small [http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg] metadata_license should be " CC-BY-SA-3.0", project_license "GPL-2.0+", according to https://spdx.org/licenses/. Displays OK in gnome-software apart from the license. The game data satisfies the requirements for "firmware" [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Binary_Firmware], and can be packaged. The license text is in CCLP?.html. + license is acceptable for Fedora (GPLv2+, "no mods" for the game data) + license is specified correctly + package name is OK + builds, install, runs OK + scriptlets are correct according to guidelines + P/R/BR look correct Just some nitpicks. Your packaging foo is very strong ;) Package is APPROVED. Not sure why this was blocking FE-Legal. Lifting. We wanted to make sure the "redistribution only, no modification" licence for the level packs was okay - it seems to match Packaging:Licensing:Shareware, but we wanted to double-check with Legal. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Shareware I'll go ahead and file a package request, then. Yeah. Not ideal, but permitted. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/tworld tworld-1.3.2-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b66f4ca0b3 tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-10cc766f66 tworld-1.3.2-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4056ef5f5b tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b66f4ca0b3 tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5cc41b463f tworld-1.3.2-3.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-79cd34e5e0 The build initially failed for EPEL6 due to libappstream-glib not being available. Since that is used only for validating the appdata.xml file, I edited the EPEL6 spec file to omit that step. tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-79cd34e5e0 tworld-1.3.2-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |