Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1466675
| Summary: | updates-testing is still enabled | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kamil Páral <kparal> |
| Component: | fedora-repos | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 26 | CC: | awilliam, dennis, dgilmore, kellin, kevin, mattdm, mboddu, mruckman, pbrobinson, robatino, sgallagh |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | fedora-repos-26-1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-07-06 22:51:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1349188 | ||
|
Description
Kamil Páral
2017-06-30 08:38:52 UTC
I'm quite sure this is a blocker, even though I don't see a particular criterion for it now. This one might be the closest one: "A fedora-release package containing the correct names, information and repository configuration for a final Fedora release must be present on release-blocking images and the appropriately versioned generic-release package must be available in the release repository." https://fedoraproject.org/wiki/Fedora_26_Final_Release_Criteria#Release_identification This does make testing that KDE updates-notifier bug easier :) I have a suggestion for the future (maybe not the change to make right now, though): maybe the sources should always have updates-testing enabled (because that's what should happen in rawhide and branched), but have a flag in the spec file which changes this with sed in the %build section? That way, the flip would be a simple specfile update rather than error-prone manual changes to the repo files in source. +1 blocker +1 blocker +1 blocker +1 blocker, indeed the criterion cited is exactly the one that covers this: "correct...repository configuration for a final Fedora release" certainly means "updates-testing should be disabled". That's +4, so accepting. generic-release-26-1 fedora-repos-26-1 fedora-release-26-1 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-459d827225 fedora-release-26-1, fedora-repos-26-1, generic-release-26-1 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-459d827225 I can confirm that in RC 1.3 in the Fedora Cloud Base image, updates-testing is no longer enabled. I can also confirm fixed with RC 1.3 Workstation Live. (In reply to Matthew Miller from comment #3) > I have a suggestion for the future (maybe not the change to make right now, > though): maybe the sources should always have updates-testing enabled > (because that's what should happen in rawhide and branched), but have a flag > in the spec file which changes this with sed in the %build section? > > That way, the flip would be a simple specfile update rather than error-prone > manual changes to the repo files in source. rawhide has a compeletely different repo file thats enabled. in rawhide fedora, updates and updates-testing are disabled. if you tried to use any of them they would all fail. the only place we have updates-testing enabled is branched before release. (In reply to Dennis Gilmore from comment #12) > rawhide has a compeletely different repo file thats enabled. in rawhide > fedora, updates and updates-testing are disabled. if you tried to use any of > them they would all fail. > > the only place we have updates-testing enabled is branched before release. I think the same thing applies -- wouldn't it be easier to change enabled/disabled for all of these things as a flag in the spec file rather than updating and rebuilding the source tarball? fedora-release-26-1, fedora-repos-26-1, generic-release-26-1 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |