Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1480961 (golang-github-howeyc-fsnotify)

Summary:	Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding
Product:	[Fedora] Fedora	Reporter:	sensor.wen
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-22 13:31:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1465889

Description sensor.wen 2017-08-13 08:25:44 UTC

Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00589823-golang-github-howeyc-fsnotify/golang-github-howeyc-fsnotify.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00589823-golang-github-howeyc-fsnotify/golang-github-howeyc-fsnotify-0.9.0-0.1.fc25.src.rpm

Description: File change notification Go language Binding

Fedora Account System Username: mosquito

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-08-13 20:54:52 UTC

rpmlint:
> golang-github-howeyc-fsnotify.src: W: summary-ended-with-dot C File change notification Go language Binding.
> golang-github-howeyc-fsnotify.src: W: invalid-license fsnotify Authors
It actually is "BSD 3-clause": License: BSD.

I'm very green with go packaging, but afaict the guidelines in https://fedoraproject.org/wiki/PackagingDrafts/Go are all followed.

+ latest version
+ package name is OK
+ license is acceptable
- license is specified incorrectly, please fix when importing
+ builds and installs OK
+ Go guideline draft is followed
+ %check does not pass but is commented out
+ BR/R/P look OK

Wouldn't it be better to change the %gotest line to something like:
{ %gotest %{import_path} } || :
so that the failures show up in the logs and it's known what needs fixing?

Package is APPROVED. Please fix license tag when uploading.

Comment 2 Gwyn Ciesla 2017-08-14 19:50:02 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify

Comment 3 Gwyn Ciesla 2017-08-14 19:50:12 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify

Comment 4 Zamir SUN 2018-07-22 13:31:19 UTC

This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.