Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1488214 (deepin-manual)
Summary: | Review Request: deepin-manual - Deepin User Manual | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | sensor.wen |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED CANTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | felixonmars, j.romildo, package-review, sztsian, zebob.m |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-06-21 15:21:53 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1465889 |
Description
sensor.wen
2017-09-04 17:30:48 UTC
Hello, - One issue with the icon you install, you need to run gtk-update-icon-cache: %post touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ] ; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi %postun touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ] ; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi and you need to Require hicolor-icon-theme: Requires: hicolor-icon-theme - Internet access is disabled during Koji and Mock builds, thus you can't download all the node modules required for the manual. You need to either to bundle them. Or better: you could package them all with node2rpm, and their dependencies… it would be a lot of work though. List of dependencies: "dependencies": { "angular": "^1.3.15", "angular-animate": "^1.3.15", "angular-gettext": "^2.0.5", "angular-hotkeys": "^1.4.5", "babel-core": "^5.1.11", "babelify": "^5.0.4", "browserify": "^9.0.4", "expect.js": "^0.3.1", "gulp": "^3.8.11", "gulp-angular-gettext": "^2.1.0", "gulp-mocha": "^2.0.1", "gulp-ng-annotate": "^0.5.2", "gulp-rename": "^1.2.2", "gulp-uglify": "^1.2.0", "jquery": "^2.1.3", "marked": "^0.3.3", "mousetrap": "^1.5.2", "url-parse": "^1.0.0" }, "devDependencies": { "gulp-sass": "^1.3.3", "gulp-sourcemaps": "^1.5.2" } Not needed anymore: - One issue with the icon you install, you need to run gtk-update-icon-cache: Version 2 has been published, it seems the build system has changed (now cmake) . I think the best course of action is to bundle the required node packages as a Source1, they are only needed at build time. Here's how I generated a node_modules.tar.gz: # git clone https://github.com/linuxdeepin/deepin-manual # cd deepin-manual # git checkout %%version # pushd src/web/ # npm install # popd # tar -czvf node_modules.tar.gz src/web/node_modules Source1: node_modules.tar.gz Also version 2 now depends on qcef: https://github.com/linuxdeepin/qcef In order to speed things up, I have prepared a SPEC for you, you just need to review it and submit it as your own if you're ok with it. It is available here: https://eclipseo.fedorapeople.org/deepin/ (In reply to Robert-André Mauchin from comment #3) > Also version 2 now depends on qcef: https://github.com/linuxdeepin/qcef > In order to speed things up, I have prepared a SPEC for you, you just need > to review it and submit it as your own if you're ok with it. It is available > here: https://eclipseo.fedorapeople.org/deepin/ Thanks. I just talked with Felix (Fedora packager and also member of the Deepin Desktop developer), he mentioned that qcef is again bundled. We will need to look into qcef de-bundling first. Qcef is bundling a precompiled cef, only for x86_64, that's not really Fedora compliant. It would be best to unbundle it. Otherwise deepin-manual would only be available on x86_64 on the programs depending on it too. Deepin take some of the files into their internal repo. So qcef is no longer compilable outside of their company. As a result, deepin-manual is not able to be packaged in Fedora. I am closing this request on behalf of the Deepin DE packaging effort. https://github.com/linuxdeepin/qcef/issues/3 |