Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1495384
| Summary: | Gluster 3.12.1 Packages require manual systemctl daemon reload after install | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Sam McLeod <mailinglists> | |
| Component: | packaging | Assignee: | Kaleb KEITHLEY <kkeithle> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | low | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | anoopcs, bugs, kkeithle, ndevos, pasik | |
| Target Milestone: | --- | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.13.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1497989 1497990 (view as bug list) | Environment: | ||
| Last Closed: | 2017-12-08 17:41:21 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1497989, 1497990 | |||
|
Description
Sam McLeod
2017-09-26 00:27:08 UTC
I think we should use the scriptlets provided by systemd: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd REVIEW: https://review.gluster.org/18418 (packaging: manual systemctl daemon reload required after install) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle) COMMIT: https://review.gluster.org/18418 committed in master by Niels de Vos (ndevos) ------ commit faf5939307cafe262ee2135621e1d3e173087e06 Author: Kaleb S. KEITHLEY <kkeithle> Date: Mon Oct 2 10:44:59 2017 -0400 packaging: manual systemctl daemon reload required after install Use the %systemd_{post,preun,postun_with_restart} macros provided I tried both install and update from 3.10.x and did not receive any warnings about needing daemon reload Reported-by: Sam McLeod <rhbugs.net> Change-Id: Ibb33a748fc4226864019765b59d1a154b7297bae BUG: 1495384 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#4) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#6) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: https://review.gluster.org/18432 (packaging: manual systemctl daemon reload required after install) posted (#7) for review on master by Kaleb KEITHLEY (kkeithle) COMMIT: https://review.gluster.org/18432 committed in master by Jeff Darcy (jeff.us) ------ commit 68d80f44a3a33050241b025476c8e171018f0edf Author: Kaleb S. KEITHLEY <kkeithle> Date: Wed Oct 4 14:22:05 2017 -0400 packaging: manual systemctl daemon reload required after install Use the %systemd_{post,preun,postun_with_restart} macros provided. Previous fix failed to build on koji Fedora 27 and 28 despite building successfully in on Fedora 2x and CentOS 6 in jenkins and Fedora 25 and 26 in koji (but with late warnings emitted at the end of the build.) Examination of the scriptlets (e.g. `rpm -qp --scripts glusterfs-server.rpm`) revealed some ugliness that is addressed by the using %{nil} lines instead of " ;" After this, builds on CentOS 6, and old Fedora 27 rawhide, and koji f27 worked without warnings or errors about macro recursion. Visual inspection of the scripts appears correct. Fresh installs on CentOS 6 and Fedora 27 rawhide worked. Updates from glusterfs-3.12.1 worked. Reported-by: Sam McLeod <rhbugs.net> Change-Id: I84e9dbc6ccd17cdfc2f7c025bdbf61e92523da79 BUG: 1495384 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report. glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html [2] https://www.gluster.org/pipermail/gluster-users/ |