Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1504026

Summary: mk-s390-cdboot fails with "TypeError: a bytes-like object is required, not 'str'"
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: loraxAssignee: Brian Lane <bcl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint-list, bcl, cstratak, dcantrell, dmach, mgracik, mkolman, wwoods
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Unspecified   
Whiteboard:
Fixed In Version: lorax-28.1-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-29 16:41:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    

Description Dan Horák 2017-10-19 10:30:32 UTC
Seems the recent switch to python3 broke the mk-s390-cdboot tool

...
2017-10-19 09:09:19,177: Creating image file /mnt/koji/compose/rawhide/Fedora-Rawhide-20171019.n.0/work/s390x/buildinstall/Server/images/product.img from contents of /var/tmp/lorax.kmpex4wp/installroot/usr/share/lorax//product/
Creating image file /mnt/koji/compose/rawhide/Fedora-Rawhide-20171019.n.0/work/s390x/buildinstall/Server/images/product.img from contents of /var/tmp/lorax.kmpex4wp/installroot/usr/share/lorax//product/
2017-10-19 09:09:46,016: command output:
Creating bootable CD-ROM image...
kernel is  : /mnt/koji/compose/rawhide/Fedora-Rawhide-20171019.n.0/work/s390x/buildinstall/Server/images/kernel.img
ramdisk is : /mnt/koji/compose/rawhide/Fedora-Rawhide-20171019.n.0/work/s390x/buildinstall/Server/images/initrd.img
parmfile is: /mnt/koji/compose/rawhide/Fedora-Rawhide-20171019.n.0/work/s390x/buildinstall/Server/images/cdboot.prm
outfile is : /mnt/koji/compose/rawhide/Fedora-Rawhide-20171019.n.0/work/s390x/buildinstall/Server/images/cdboot.img
Traceback (most recent call last):
  File "/usr/bin/mk-s390-cdboot", line 112, in <module>
    main()
  File "/usr/bin/mk-s390-cdboot", line 109, in main
    configure_kernel(args.outfile, args.parmfile, size)
  File "/usr/bin/mk-s390-cdboot", line 80, in configure_kernel
    out_fd.write("\0" * KERNEL_CMDLINE_SIZE)
TypeError: a bytes-like object is required, not 'str'
...

for full log please see https://kojipkgs.fedoraproject.org//work/tasks/1853/22541853/mock_output.log

Version-Release number of selected component (if applicable):
lorax.s390x 28.0-1.fc28

Comment 1 Martin Kolman 2017-10-19 11:05:50 UTC
Looks like this might be another fallout of the Python 3.6.3 bytes/strings change (bug 1501511).

Comment 2 Charalampos Stratakis 2017-10-19 14:44:42 UTC
Possibly related upstream commit: https://github.com/python/cpython/commit/a1115e1a0454f0548f96cace6ee97b286dfa1c0d

Comment 3 Charalampos Stratakis 2017-10-19 15:56:23 UTC
Hmm I see from the changelog though: "Convert mk-s390-cdboot to python3 (#1497141)" so I don't think it's related. to the pykickstart issue.

Comment 4 Brian Lane 2017-10-19 21:44:09 UTC
Correct, this was fallout from switching to python3 and not giving it a proper try.