Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1505026
Summary: | Review Request: brightlight - CLI tool to change screen back light brightness | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Justin W. Flory (he/him) <foss> |
Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | ignatenko:
fedora-review+
|
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-11-15 17:40:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Justin W. Flory (he/him)
2017-10-21 07:35:46 UTC
Please give RAW links to spec/srpm next time ;) > %global debug_package %{nil} No, this is rutning off debug while you really need it. > URL: https://github.com/multiplexd/%{name} My personal preference is to have links clickable ;) > Source0: https://github.com/multiplexd/%{name}/archive/v%{version}.tar.gz Give it meaningful name and you can also simplify it: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > BuildRequires: libbsd libbsd-devel is enough > make %{?_smp_mflags} %make_build > rm -rf $RPM_BUILD_ROOT Not needed > install -p -m 755 %{_builddir}/%{name}-%{version}/%{name} %{buildroot}%{_bindir} install -p -m 755 %{name} %{buildroot}%{_bindir}/%{name} --- And the main and big problem is that CFLAGS and LDFLAGS are ignored, you need to patch Makefile.. Or just stop using makefile ;) This is what I see from build.log: gcc brightlight.c -o brightlight -O2 -fstack-protector-strong -lbsd while it should be: gcc brightlight.c -o brightlight -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -lbsd I've created patch for upstream which you can use: https://github.com/multiplexd/brightlight/pull/1 This will fix problem with debuginfo thing you have. I have submitted the fixes to the SPEC file in the repo. https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SPECS/brightlight.spec https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SRPMS/brightlight-5-1.fc26.src.rpm Additionally, since the maintainer accepted your patch and cut a new release, I also updated my SPEC to correspond to v5. I was able to build this successfully in Koji (F27) and in my COPR. https://koji.fedoraproject.org/koji/taskinfo?taskID=22588233 https://copr.fedorainfracloud.org/coprs/jflory7/brightlight/build/646671/ > Source0: %{url}/archive/v%{version}.tar.gz
Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
Otherwise looks good.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/brightlight brightlight-5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951 brightlight-5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951 brightlight-5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3f085b86e brightlight-5-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3f085b86e brightlight-5-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8071ee299f brightlight-5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951 brightlight-5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8071ee299f brightlight-5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. brightlight-5-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bb6b5c4df7 brightlight-5-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bb6b5c4df7 brightlight-5-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. brightlight-5-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |