Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1506331

Summary: Review Request: golang-github-tjfoc-gmsm - GM SM2/3/4 library based on Golang
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-04 21:09:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabio Valentini 2017-10-25 17:57:08 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-tjfoc-gmsm.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc26.src.rpm

Description: GM SM2/3/4 library based on Golang
Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=22695467
With tests passing, and PPC64 failing as expected.

I need this new package for updating github.com/AudriusButkevicius/kcp-go and github.com/xtaci/kcp-go to their latest versions / snapshots.

Comment 1 Robert-André Mauchin 🐧 2017-10-26 14:32:34 UTC
Hello,


 - golang-github-tjfoc-gmsm-devel.noarch: W: invalid-license ASLv2.0

Correct short format for Apache 2.0 is 'ASL 2.0', not ASLv2.0.


Package is good otherwise and is accepted.

Comment 2 Fabio Valentini 2017-10-26 16:22:30 UTC
Oops, that's clearly a mistake ... I definitely should check that (ASL 2.0) every time I use it, because I seem to spell it wrongly every 2nd time. I'll fix it before importing. Thanks for the review!

Comment 3 Gwyn Ciesla 2017-10-26 16:33:24 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-tjfoc-gmsm

Comment 4 Fedora Update System 2017-10-27 13:16:38 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9190788abf

Comment 5 Fedora Update System 2017-10-27 15:39:44 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9190788abf

Comment 6 Fedora Update System 2017-10-27 18:50:08 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a933532f5

Comment 7 Fedora Update System 2017-10-28 12:17:44 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-20c0d32691

Comment 8 Fedora Update System 2017-11-04 21:09:30 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-11-04 22:13:32 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-11-11 03:07:34 UTC
golang-github-tjfoc-gmsm-1.0.1-1.20171023.git9d99fac.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.