Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1509590
Summary: | Review Request: cool-retro-term - Terminal emulator mimicking a CRT display | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Artur Frenszek-Iwicki <fedora> |
Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | ngompa13, package-review |
Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-12-10 05:08:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1511966 | ||
Bug Blocks: |
Description
Artur Frenszek-Iwicki
2017-11-04 23:30:22 UTC
I ran the package through fedora-review and a few issues turned up. spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-2.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22938177 You should consider unbundling qmltermwidget... I did so a while back in a COPR repo: https://copr.fedorainfracloud.org/coprs/ngompa/cool-retro-term/ Feel free to take those for making official packages. Thanks! I'll take a look at those. I unbundled qmltermwidget using the spec files from Neal's copr. I post new links to the spec and srpm below. No koji build due to waiting for the dependency to be accepted. spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-3.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-3.src.rpm Taking this review. qmltermwidget, which is a dependency of this package, has been accepted. Hence, I post a link to a koji build. spec and SRPM as in the previous post (1.0.1-3). https://koji.fedoraproject.org/koji/taskinfo?taskID=23288444 Review notes: [!] Spec file is named incorrectly. It should be named as cool-retro-term.spec [!] Non-usage of %qt5_qmake macro. Please consider using it so that our distro-wide compiler settings are applied. [!] Missing runtime dependency on qmltermwidget. QML modules do not yet have automatic dependencies, so they need to be specified. [+] Software is licensed under a valid license, and license content is included correctly [!] Notable issues from rpmlint from fedora-review: - cool-retro-term.x86_64: W: spurious-executable-perm /usr/share/man/man1/cool-retro-term.1.gz Thanks for the review. The spec file name inside the SRPM has a correct name; it's just that I prefer to version the linked specs during the review process. Anyway: spec: https://svgames.pl/fedora/cool-retro-term-1.0.1-4.spec srpm: https://svgames.pl/fedora/cool-retro-term-1.0.1-4.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23376633 I don't see any remaining issues. PACKAGE APPROVED. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cool-retro-term cool-retro-term-1.0.1-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a03ca8d850 cool-retro-term-1.0.1-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dfcc097b97 cool-retro-term-1.0.1-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b3c73d2cbc cool-retro-term-1.0.1-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-603b011e54 cool-retro-term-1.0.1-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-12f2895029 cool-retro-term-1.0.1-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-813b682539 cool-retro-term-1.0.1-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-813b682539 cool-retro-term-1.0.1-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-12f2895029 cool-retro-term-1.0.1-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. cool-retro-term-1.0.1-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. cool-retro-term-1.0.1-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |