Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1524133 (deepin-calculator)
Summary: | Review Request: deepin-calculator - an easy to use calculator | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | sensor.wen |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jan.public, package-review, sensor.wen, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-07-22 13:32:23 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1465889 |
Description
sensor.wen
2017-12-10 10:20:07 UTC
- update-desktop-database is not needed in %post and %postun since Fedora 25. See https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#desktop-database - I've got a build error: src/main.cpp:3:10: fatal error: DHiDPIHelper: No such file or directory #include <DHiDPIHelper> ^~~~~~~~~~~~~~ compilation terminated. It seems DHiDPIHelper was added in a recent version of dtkwidget, at least 2.0.2 See https://github.com/linuxdeepin/dtkwidget/commit/0fdbcf605243bdc13a84abd08bf30639665f897f#diff-694e4721164b162e1134839539bc385f Thus you need to add a correct minimum version to the BR: BuildRequires: pkgconfig(dtkwidget) >= 2.0.2 And you need to update the version of dtkwidget available in Fedora. The latest version you packaged is 2.0.1. http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/x86_64/os/Packages/d/dtkwidget-devel-2.0.6.1-1.fc29.x86_64.rpm Updated the latest version of dtkwidget. Please review again. - Bump to 1.0.2. - This: sed -i 's|=lupdate|=lupdate-qt5|;s|=lrelease|=lrelease-qt5|' %{name}.pro doesn't work as there is no lupdate/lrelease in the pro file. Thus translation fails. There's a script here: translations/translate_generation.sh which contains lrelease that you could replace: sed -i 's|lrelease|lrelease-qt5|' translations/translate_generation.sh - This scriplet is not needed anymore, it has been automated: %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null ||: /usr/bin/update-desktop-database -q ||: %postun if [ $1 -eq 0 ]; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null ||: /usr/bin/gtk-update-icon-cache -f -t -q %{_datadir}/icons/hicolor ||: fi /usr/bin/update-desktop-database -q ||: %posttrans /usr/bin/gtk-update-icon-cache -f -t -q %{_datadir}/icons/hicolor ||: Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00730017-deepin-calculator/deepin-calculator.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00730017-deepin-calculator/deepin-calculator-1.0.2-1.fc26.src.rpm Release 1.0.2. Thank you for your help. - You need to add: Requires: hicolor-icon-theme to own these directories: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/dman, /usr/share/icons/hicolor/scalable - There are source files with incorrect obsolete FSF address, patch them in %prep with the new address and notify upstream about it: deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatcommon.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatcommon.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconst.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconst.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconvert.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatconvert.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floaterf.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floaterf.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatexp.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatexp.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatgamma.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatgamma.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floathmath.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floathmath.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatincgamma.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatio.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatio.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatipower.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatipower.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlog.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlog.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlogic.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlogic.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlong.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatlong.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatnum.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatnum.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatpower.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatpower.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatseries.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floatseries.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floattrig.c deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/floattrig.h deepin-calculator-debugsource.x86_64: E: incorrect-fsf-address deepin-calculator-1.0.2-1.fc29.x86_64/math/number.c sed -i "s|59 Temple Place, Suite 330|51 Franklin Street, Fifth Floor|;s|Boston, MA 02111-1307 USA.|Boston, MA 02110-1335, USA.|" math/*.{c,h} SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00731890-deepin-calculator/deepin-calculator.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00731890-deepin-calculator/deepin-calculator-1.0.2-1.fc26.src.rpm Fixed it. Thank you. Package approved. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-calculator This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. |